Bug in git-gui

[Clemens Haffner <c.f.haffner@gmail.com>]

Hi,

I think I found a bug in git-gui on Windows (Windows 10 64 bit)

git-gui Version 0.21.GITGUI
git Version: 2.44.0.windows.1

To reproduce: (I have not tested it with rsa keys)

- Create an ed25519 key with a passphrase (--> .ssh/id_ed25519). 
Help->Show ssh key detects that key perfectly and shows the Public key 
to copy
- Push something to a repository:
--> it will fail.

 >  Pushing to xxx.xxx:clemens/test_repo.git
 >  CreateProcessW failed error:193
 >  ssh_askpass: posix_spawnp: Unknown error
 >  git@git.xxx.xxx: Permission denied (publickey).
 >  fatal: Could not read from remote repository.
 >
 >  Please make sure you have the correct access rights
 >  and the repository exists.

- When using a key without a passphrase, it works perfectly well.
- When using ssh-agent with a key that uses a passphrase, it also works 
well.

 >  Pushing to git.xxx.xxx:clemens/test_repo.git
 >  To git.xxx.xxx:clemens/test_repo.git
 >   = [up to date]      rev1 -> rev1
 >  updating local tracking ref 'refs/remotes/origin/rev1'
 >  Everything up-to-date

this bug must be in git gui, as it works perfectly fine via git bash.

"git push" spawns a new window, which asks for the passphrase. After 
entering the phrase git works as intended.

It seems to me that the git gui cant spawn that window where it asks for 
the key.

If that helps:
I'm using Microsofts OpenSSH implementation:

 >  $ ssh -V
 >  OpenSSH_for_Windows_8.1p1, LibreSSL 3.0.2

Greetings,
Clemens Haffner