From: "Rubén Justo" <rjusto@gmail.com>
To: Git List <git@vger.kernel.org>
Subject: [PATCH 2/3] t/test-tool: handle -c <name>=<value> arguments
Date: Tue, 9 Jan 2024 16:29:57 +0100 [thread overview]
Message-ID: <6a4d6a56-ab6f-4557-a5a3-1713f57cbfc9@gmail.com> (raw)
In-Reply-To: <7c68392c-af2f-4999-ae64-63221bf7833a@gmail.com>
Soon we're going to need to pass configuration values to a command in
test-tool.
Let's teach test-tool to take config values via command line arguments.
Signed-off-by: Rubén Justo <rjusto@gmail.com>
---
t/helper/test-tool.c | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/t/helper/test-tool.c b/t/helper/test-tool.c
index d9f57c20db..7eba4ec9ab 100644
--- a/t/helper/test-tool.c
+++ b/t/helper/test-tool.c
@@ -3,9 +3,10 @@
#include "test-tool-utils.h"
#include "trace2.h"
#include "parse-options.h"
+#include "config.h"
static const char * const test_tool_usage[] = {
- "test-tool [-C <directory>] <command> [<arguments>...]]",
+ "test-tool [-C <directory>] [-c <name>=<value>] <command> [<arguments>...]",
NULL
};
@@ -106,6 +107,13 @@ static NORETURN void die_usage(void)
exit(128);
}
+static int parse_config_option(const struct option *opt, const char *arg,
+ int unset)
+{
+ git_config_push_parameter(arg);
+ return 0;
+}
+
int cmd_main(int argc, const char **argv)
{
int i;
@@ -113,6 +121,9 @@ int cmd_main(int argc, const char **argv)
struct option options[] = {
OPT_STRING('C', NULL, &working_directory, "directory",
"change the working directory"),
+ OPT_CALLBACK('c', NULL, NULL, "<name>=<value>",
+ "pass a configuration parameter to the command",
+ parse_config_option),
OPT_END()
};
--
2.42.0
next prev parent reply other threads:[~2024-01-09 15:30 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-09 15:25 [PATCH 0/3] allow disabling the automatic hint in advise_if_enabled() Rubén Justo
2024-01-09 15:29 ` [PATCH 1/3] t/test-tool: usage description Rubén Justo
2024-01-09 18:19 ` Junio C Hamano
2024-01-09 15:29 ` Rubén Justo [this message]
2024-01-09 18:19 ` [PATCH 2/3] t/test-tool: handle -c <name>=<value> arguments Junio C Hamano
2024-01-09 18:20 ` Taylor Blau
2024-01-09 15:30 ` [PATCH 3/3] advice: allow disabling the automatic hint in advise_if_enabled() Rubén Justo
2024-01-09 18:23 ` Junio C Hamano
2024-01-09 18:27 ` Taylor Blau
2024-01-09 19:57 ` Junio C Hamano
2024-01-10 12:11 ` Rubén Justo
2024-01-10 11:02 ` Jeff King
2024-01-10 11:39 ` Rubén Justo
2024-01-10 14:18 ` Dragan Simic
2024-01-10 14:32 ` Rubén Justo
2024-01-10 14:44 ` Dragan Simic
2024-01-10 16:22 ` Junio C Hamano
2024-01-10 17:45 ` Dragan Simic
2024-01-11 8:04 ` Jeff King
2024-01-18 6:15 ` Dragan Simic
2024-01-18 18:26 ` Junio C Hamano
2024-01-18 18:53 ` Dragan Simic
2024-01-18 20:19 ` Junio C Hamano
2024-01-18 20:50 ` Dragan Simic
2024-01-20 11:31 ` Rubén Justo
2024-01-20 15:31 ` Dragan Simic
2024-01-10 16:14 ` Junio C Hamano
2024-01-09 18:28 ` [PATCH 0/3] " Taylor Blau
2024-01-09 22:32 ` Junio C Hamano
2024-01-10 12:40 ` Rubén Justo
2024-01-12 10:05 ` [PATCH] advice: " Rubén Justo
2024-01-12 22:19 ` Junio C Hamano
2024-01-13 7:38 ` Jeff King
2024-01-16 4:56 ` Junio C Hamano
2024-01-15 11:24 ` Rubén Justo
2024-01-15 14:28 ` [PATCH v2] " Rubén Justo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a4d6a56-ab6f-4557-a5a3-1713f57cbfc9@gmail.com \
--to=rjusto@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).