From: Derrick Stolee <stolee@gmail.com>
To: Edmundo Carmona Antoranz <eantoranz@gmail.com>,
dstolee@microsoft.com, git@vger.kernel.org, peff@peff.net
Subject: Re: [PATCH v2] blame.c: replace instance of !oidcmp for oideq
Date: Wed, 9 Sep 2020 08:39:56 -0400 [thread overview]
Message-ID: <6b84f112-7e3f-3a78-3766-033fcf494464@gmail.com> (raw)
In-Reply-To: <20200908211053.807194-1-eantoranz@gmail.com>
On 9/8/2020 5:10 PM, Edmundo Carmona Antoranz wrote:
> 0906ac2b54b introduced a call to oidcmp() that should be
> replaced by oideq() (the latter introduced in 14438c4).
Short-OIDs on their own are not enough. Please use the
format "abbreviated hash (subject, date)" as mentioned
in my earlier reply:
0906ac2b (blame: use changed-path Bloom filters, 2020-04-16)
14438c4 (introduce hasheq() and oideq(), 2018-08-28)
See Documentation/SubmittingPatches [1] for more information
on this.
[1] https://github.com/git/git/blob/3a238e539bcdfe3f9eb5010fd218640c1b499f7a/Documentation/SubmittingPatches#L144-L165
Thanks,
-Stolee
next prev parent reply other threads:[~2020-09-09 12:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-08 21:10 [PATCH v2] blame.c: replace instance of !oidcmp for oideq Edmundo Carmona Antoranz
2020-09-09 12:39 ` Derrick Stolee [this message]
2020-09-09 13:10 ` Edmundo Carmona Antoranz
2020-09-09 18:35 ` Junio C Hamano
2020-09-09 19:13 ` Edmundo Carmona Antoranz
2020-09-09 20:08 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b84f112-7e3f-3a78-3766-033fcf494464@gmail.com \
--to=stolee@gmail.com \
--cc=dstolee@microsoft.com \
--cc=eantoranz@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).