Re: [PATCH v2 0/4] Integrate the sparse index with 'git apply' and interactive add, checkout, and reset

[Derrick Stolee <stolee@gmail.com>]

On 5/16/2025 11:32 AM, Elijah Newren wrote:
> On Fri, May 16, 2025 at 7:55 AM Derrick Stolee via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
>>

>>      -    Add more test cases that confirm that these interactive add options work
>>      -    with the sparse index. One interesting aspect here is that the '-i'
>>      -    option avoids expanding the sparse index when a sparse directory exists
>>      -    on disk while the '-p' option does hit the ensure_full_index() method.
>>      -    This leaves some room for improvement, but this case should be atypical
>>      -    as users should remain within their sparse-checkout.
>>      +    Moving that integration point earlier in cmd_add() allows 'git add -p'
>>      +    and 'git add -p' to operate without expanding a sparse index to a full
>>      +    one.
> 
> Was the second 'git add -p' meant to be 'git add -i'?

You are right. The second one should be 'git add -i'.

And regarding 'next', I do expect my v1 to be ejected from 'next' while
review continues on this v2. If instead it gets merged to 'master', then
I'll prepare a new series on top that applies the learnings from this
review.

Thanks,
-Stolee