From: "René Scharfe" <l.s.r@web.de>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Jacob Keller <jacob.keller@gmail.com>
Subject: Re: [PATCH] various: disallow --no-no-OPT for --no-opt options
Date: Wed, 19 Apr 2017 15:44:35 +0200 [thread overview]
Message-ID: <6d9cedc4-3d3d-61a8-080c-98126c555e1b@web.de> (raw)
In-Reply-To: <CACBZZX7Y2cqabLMkx35ZU88Y3+8zffP5hxa8haThMaErbfhcfA@mail.gmail.com>
Am 19.04.2017 um 15:19 schrieb Ævar Arnfjörð Bjarmason:
> I mean a bug in my patch, i.e. I meant to remove --no-no-OPT in cases
> of --no-OPT but also removed --OPT unintentionally, but anyway, let's
> drop this one, Jacob's patch is better.
Ah, OK.
You also wondered why no tests complained. Good question. Would it
make sense to test every option *and* its negation? That would double
the number of tests in order to check a parseopt feature. Hmm, not
sure. More test coverage would be good, but I doubt we'd ever arrive at
100% for this.
If you had converted --no-doubt in t/helper/test-parse-options.c to
OPT_BOOL_NONEG instead of or in addition to adding the new flag --no-neg
then you'd seen the effect in t0040.
René
prev parent reply other threads:[~2017-04-19 13:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-18 17:09 [PATCH] various: disallow --no-no-OPT for --no-opt options Ævar Arnfjörð Bjarmason
2017-04-18 22:29 ` René Scharfe
2017-04-19 1:41 ` Jeff King
2017-04-19 2:40 ` Junio C Hamano
2017-04-19 2:50 ` Jeff King
2017-04-19 7:02 ` Ævar Arnfjörð Bjarmason
2017-04-19 9:08 ` Jacob Keller
2017-04-19 15:05 ` Jeff King
2017-04-19 7:00 ` Ævar Arnfjörð Bjarmason
2017-04-19 13:11 ` René Scharfe
2017-04-19 13:19 ` Ævar Arnfjörð Bjarmason
2017-04-19 13:44 ` René Scharfe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d9cedc4-3d3d-61a8-080c-98126c555e1b@web.de \
--to=l.s.r@web.de \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jacob.keller@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).