From: "Jakub Narębski" <jnareb@gmail.com>
To: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Cc: Jeff Hostetler <git@jeffhostetler.com>
Subject: Re: [PATCH] contrib/git-resurrect.sh: do not write \t for HT in sed scripts
Date: Sun, 2 Apr 2017 11:58:45 +0200 [thread overview]
Message-ID: <7028b4eb-aa2b-aaf6-764d-cffab24a9968@gmail.com> (raw)
In-Reply-To: <xmqqd1cwwyr5.fsf_-_@gitster.mtv.corp.google.com>
W dniu 01.04.2017 o 06:14, Junio C Hamano pisze:
> Just like we did in 0d1d6e50 ("t/t7003: replace \t with literal tab
> in sed expression", 2010-08-12), avoid writing "\t" for HT in sed
> scripts, which is not portable.
I guess it is not possible to use HT variable (similar to LF that we
have in t/test-lib.sh, and which is defined by some scripts) set to
literal tab
HT=" "
wouldn't work there, is it?
Using this variable would make literal tab character more visible.
--
Jakub Narębski
next prev parent reply other threads:[~2017-04-02 9:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-31 17:32 [PATCH] name-hash: fix buffer overrun git
2017-03-31 17:32 ` git
2017-03-31 19:35 ` Junio C Hamano
2017-03-31 21:18 ` Junio C Hamano
2017-03-31 23:18 ` Junio C Hamano
2017-04-01 4:12 ` Junio C Hamano
2017-04-01 12:12 ` Johannes Schindelin
2017-04-01 18:16 ` Junio C Hamano
2017-04-01 4:14 ` [PATCH] contrib/git-resurrect.sh: do not write \t for HT in sed scripts Junio C Hamano
2017-04-02 9:58 ` Jakub Narębski [this message]
2017-04-02 16:46 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7028b4eb-aa2b-aaf6-764d-cffab24a9968@gmail.com \
--to=jnareb@gmail.com \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).