From: "Tomáš Trnka" <trnka@scm.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Taylor Blau <me@ttaylorr.com>,
Jeff King <peff@peff.net>,
Jonathan Tan <jonathantanmy@google.com>,
hanyang.tony@bytedance.com
Subject: Re: [RFC PATCH resend] builtin/repack: Honor --keep-pack and .keep when repacking promisor objects
Date: Fri, 31 Jan 2025 16:17:08 +0100 [thread overview]
Message-ID: <7102402.jJDZkT8p0M@electra> (raw)
In-Reply-To: <xmqq34h0aq65.fsf@gitster.g>
On Thursday, 30 January 2025 23:32:34, CET Junio C Hamano wrote:
> I don't have a strong opinion about the technical aspects of this
> patch to be a reviewer. I have no idea how you decided whom to Cc:,
I'm sorry again for spamming you unnecessarily and many thanks for suggesting
more suitable reviewers.
Being a complete newcomer to Git development, I went by what the git-contacts
tool suggested when I gave it my patch, since its output seemed to roughly
agree with git log on builtin/repack.c, plus I also thought you might have a
high-level opinion on where the test belongs. I didn't check the mailing list
archives too thoroughly, so I was not aware of those discussion threads.
2T
next prev parent reply other threads:[~2025-01-31 15:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-30 8:11 [RFC PATCH resend] builtin/repack: Honor --keep-pack and .keep when repacking promisor objects Tomáš Trnka
2025-01-30 22:32 ` Junio C Hamano
2025-01-31 15:17 ` Tomáš Trnka [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-01-29 10:02 Tomáš Trnka
2025-01-30 2:26 ` brian m. carlson
2025-01-30 8:09 ` Tomáš Trnka
2025-02-10 11:38 ` [External] " Han Young
2025-02-10 12:52 ` Tomáš Trnka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7102402.jJDZkT8p0M@electra \
--to=trnka@scm.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hanyang.tony@bytedance.com \
--cc=jonathantanmy@google.com \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).