Git development
 help / color / mirror / Atom feed
From: "Philip Oakley" <philipoakley@iee.org>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: "Git Mailing list" <git@vger.kernel.org>
Subject: Re: "git bisect run make" adequate to locate first unbuildable commit?
Date: Fri, 9 Feb 2018 22:44:12 -0000	[thread overview]
Message-ID: <7135CFE5288C49EEA02785C1F407B46D@PhilipOakley> (raw)
In-Reply-To: alpine.LFD.2.21.1802091553290.17104@localhost.localdomain

From: "Robert P. J. Day" <rpjday@crashcourse.ca>
> On Fri, 9 Feb 2018, Philip Oakley, CEng MIET wrote:
(apologies for using the fancy letters after the name ID...)
>
>> From: "Robert P. J. Day" <rpjday@crashcourse.ca>
>> >
>> > writing a short tutorial on "git bisect" and, all the details of
>> > special exit code 125 aside, if one wanted to locate the first
>> > unbuildable commit, would it be sufficient to just run?
>> >
>> >  $ git bisect run make
>> >
>> > as i read it, make returns either 0, 1 or 2 so there doesn't appear
>> > to be any possibility of weirdness with clashing with a 125 exit code.
>> > am i overlooking some subtle detail here i should be aware of? thanks.
>> >
>> > rday
>>
>> In the spirit of pedanticism, one should also clarify the word
>> "first", in that it's not a linear search for _an_ unbuildable
>> commit, but that one is looking for the transition between an
>> unbroken sequence of unbuildable commits, which transitions to
>> buildable commits, and its the transition that is sought. (there
>> could be many random unbuildable commits within a sequence in some
>> folks' processes!)
>
>  quite so, i should have been more precise.
>
> rday

The other two things that may be happening (in the wider bisect discussion) 
that I've heard of are:
1. there may be feature branches that bypass the known good starting commit, 
which can cause understanding issues as those side branches that predate the 
start point are also considered potential bu commits.
2. if you just want the first parent check for the bad commit point, that 
mark the second parents of merges as being good.

Also, I'd expect that the skipped commits aren't 'counted' (too hard?) for 
the bisect algorithm's reporting.

https://stackoverflow.com/questions/5638211/how-do-you-get-git-bisect-to-ignore-merged-branches 
contains a number of the ideas..

Philip


  reply	other threads:[~2018-02-09 22:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-09 13:20 "git bisect run make" adequate to locate first unbuildable commit? Robert P. J. Day
2018-02-09 13:47 ` Christian Couder
2018-02-09 20:48 ` Philip Oakley, CEng MIET
2018-02-09 20:54   ` Robert P. J. Day
2018-02-09 22:44     ` Philip Oakley [this message]
2018-02-12 10:19       ` Robert P. J. Day
2018-02-12 13:05         ` SZEDER Gábor
2018-02-13 12:41       ` Robert P. J. Day

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7135CFE5288C49EEA02785C1F407B46D@PhilipOakley \
    --to=philipoakley@iee.org \
    --cc=git@vger.kernel.org \
    --cc=rpjday@crashcourse.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox