From: Jay Soffian <jaysoffian@gmail.com>
To: git@vger.kernel.org
Cc: Jay Soffian <jaysoffian@gmail.com>, Jeff King <peff@peff.net>,
Junio C Hamano <gitster@pobox.com>
Subject: [PATCH 12/23] builtin-remote: name remote_refs consistently
Date: Tue, 24 Feb 2009 04:51:00 -0500 [thread overview]
Message-ID: <713e5cc2722a0eacd5b14146b01bb5d455870474.1235467368.git.jaysoffian@gmail.com> (raw)
In-Reply-To: <cover.1235467368.git.jaysoffian@gmail.com>
Clarify the code a bit by consistently referring to the remote refs
returned by transport_get_remote_refs() as remote_refs.
Signed-off-by: Jay Soffian <jaysoffian@gmail.com>
---
builtin-remote.c | 19 ++++++++++---------
1 files changed, 10 insertions(+), 9 deletions(-)
diff --git a/builtin-remote.c b/builtin-remote.c
index 48d668e..d5c808c 100644
--- a/builtin-remote.c
+++ b/builtin-remote.c
@@ -238,13 +238,14 @@ static int handle_one_branch(const char *refname,
return 0;
}
-static int get_ref_states(const struct ref *ref, struct ref_states *states)
+static int get_ref_states(const struct ref *remote_refs, struct ref_states *states)
{
struct ref *fetch_map = NULL, **tail = &fetch_map;
+ struct ref *ref;
int i;
for (i = 0; i < states->remote->fetch_refspec_nr; i++)
- if (get_fetch_map(ref, states->remote->fetch + i, &tail, 1))
+ if (get_fetch_map(remote_refs, states->remote->fetch + i, &tail, 1))
die("Could not get fetch map for refspec %s",
states->remote->fetch_refspec[i]);
@@ -271,7 +272,7 @@ static int get_ref_states(const struct ref *ref, struct ref_states *states)
return 0;
}
-static int get_head_names(const struct ref *refs,
+static int get_head_names(const struct ref *remote_refs,
const char *remote_name, struct ref_states *states)
{
struct ref *ref, *matches = NULL;
@@ -282,8 +283,8 @@ static int get_head_names(const struct ref *refs,
refspec.pattern = 1;
refspec.src = refspec.dst = "refs/heads/";
states->heads.strdup_strings = 1;
- get_fetch_map(refs, &refspec, &fetch_map_tail, 0);
- guess_remote_head(refs, fetch_map, NULL, &matches);
+ get_fetch_map(remote_refs, &refspec, &fetch_map_tail, 0);
+ guess_remote_head(remote_refs, fetch_map, NULL, &matches);
for(ref = matches; ref; ref = ref->next)
string_list_append(abbrev_branch(ref->name), &states->heads);
@@ -667,7 +668,7 @@ static int get_remote_ref_states(const char *name,
int query)
{
struct transport *transport;
- const struct ref *ref;
+ const struct ref *remote_refs;
states->remote = remote_get(name);
if (!states->remote)
@@ -678,11 +679,11 @@ static int get_remote_ref_states(const char *name,
if (query) {
transport = transport_get(NULL, states->remote->url_nr > 0 ?
states->remote->url[0] : NULL);
- ref = transport_get_remote_refs(transport);
+ remote_refs = transport_get_remote_refs(transport);
transport_disconnect(transport);
- get_head_names(ref, name, states);
- get_ref_states(ref, states);
+ get_head_names(remote_refs, name, states);
+ get_ref_states(remote_refs, states);
}
return 0;
--
1.6.2.rc1.291.g83eb
next prev parent reply other threads:[~2009-02-24 9:54 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1235467368.git.jaysoffian@gmail.com>
2009-02-24 9:50 ` [PATCH 01/23] builtin-clone: move locate_head() to remote.c so it can be re-used Jay Soffian
2009-02-24 9:50 ` [PATCH 02/23] builtin-remote: move duplicated cleanup code its own function Jay Soffian
2009-02-24 9:50 ` [PATCH 03/23] builtin-remote: teach show to display remote HEAD Jay Soffian
2009-02-24 9:50 ` [PATCH 04/23] builtin-remote: add set-head subcommand Jay Soffian
2009-02-24 9:50 ` [PATCH 05/23] builtin-remote: better handling of multiple remote HEADs Jay Soffian
2009-02-24 9:50 ` [PATCH 06/23] remote.c: make match_refs() copy src ref before assigning to peer_ref Jay Soffian
2009-02-24 9:50 ` [PATCH 07/23] remote.c: don't short-circuit match_refs() when error in match_explicit_refs() Jay Soffian
2009-02-24 9:50 ` [PATCH 08/23] refactor duplicated get_local_heads() to remote.c Jay Soffian
2009-02-24 9:50 ` [PATCH 09/23] refactor duplicated ref_newer() " Jay Soffian
2009-02-24 9:50 ` [PATCH 10/23] string-list: new for_each_string_list() function Jay Soffian
2009-02-24 9:50 ` [PATCH 11/23] builtin-remote: rename variable and eliminate redundant function call Jay Soffian
2009-02-24 9:51 ` Jay Soffian [this message]
2009-02-24 9:51 ` [PATCH 13/23] builtin-remote: remove unused code in get_ref_states Jay Soffian
2009-02-24 9:51 ` [PATCH 14/23] builtin-remote: fix two inconsistencies in the output of "show <remote>" Jay Soffian
2009-02-24 9:51 ` [PATCH 15/23] builtin-remote: make get_remote_ref_states() always populate states.tracked Jay Soffian
2009-02-24 9:51 ` [PATCH 16/23] builtin-remote: refactor get_remote_ref_states() Jay Soffian
2009-02-24 9:51 ` [PATCH 17/23] builtin-remote: new show output style Jay Soffian
2009-02-24 9:51 ` [PATCH 18/23] builtin-remote: new show output style for push refspecs Jay Soffian
2009-02-24 9:51 ` [PATCH 19/23] test scripts: refactor start_httpd helper Jay Soffian
2009-02-24 9:51 ` [PATCH 20/23] add basic http clone/fetch tests Jay Soffian
2009-02-24 9:51 ` [PATCH 21/23] refactor find_refs_by_name to accept const list Jay Soffian
2009-02-24 9:51 ` [PATCH 22/23] remote: refactor guess_remote_head Jay Soffian
2009-02-24 9:51 ` [PATCH 23/23] remote: use exact HEAD lookup if it is available Jay Soffian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=713e5cc2722a0eacd5b14146b01bb5d455870474.1235467368.git.jaysoffian@gmail.com \
--to=jaysoffian@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).