git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Robert Watson <robert.oo.watson@gmail.com>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: uncommon shell code
Date: Fri, 23 Sep 2005 09:32:26 +0100	[thread overview]
Message-ID: <72499e3b05092301322a145e52@mail.gmail.com> (raw)
In-Reply-To: <7vu0gclpyo.fsf@assigned-by-dhcp.cox.net>

On 9/22/05, Junio C Hamano <junkio@cox.net> wrote:
> Robert Watson <robert.oo.watson@gmail.com> writes:
>
> > I found the following shell code in git-tag.sh (and others):
>
> My fault; see point 2. in this article:
>
>         http://marc.theaimsgroup.com/?l=git&m=112386506308820&w=2
>
> Please either get used to it or wait until I decide to modernize
> the scripts wholesale, whichever comes first.
>

I see.  I thought I was old fashioned by sticking to test instead of
[] (that is your point 1), but obviously I am not old enough ;)

Well, it's fine now that I know what it is.  But it hurts readability,
and probably it's a good idea to simplify it.  Any reasonable shell
should built-in test(1)?

Robertoo

  reply	other threads:[~2005-09-23  8:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-22 14:32 uncommon shell code Robert Watson
2005-09-22 22:03 ` Junio C Hamano
2005-09-23  8:32   ` Robert Watson [this message]
2005-09-23  9:00     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=72499e3b05092301322a145e52@mail.gmail.com \
    --to=robert.oo.watson@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).