From: Jonathan Chang <ttjtftx@gmail.com>
To: Git Mailing List <git@vger.kernel.org>
Cc: "Jonathan Chang" <ttjtftx@gmail.com>,
"Christian Couder" <christian.couder@gmail.com>,
"Eric Sunshine" <sunshine@sunshineco.com>,
"Thomas Gummerer" <t.gummerer@gmail.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: [GSoC][PATCH v4 4/5] t0000: use test_cmp instead of "test" builtin
Date: Sat, 30 Mar 2019 22:27:57 +0800 [thread overview]
Message-ID: <731463ed9892c283b6acb0ce69e097769e43de62.1553954776.git.ttjtftx@gmail.com> (raw)
In-Reply-To: <cover.1553954776.git.ttjtftx@gmail.com>
Signed-off-by: Jonathan Chang <ttjtftx@gmail.com>
---
t/t0000-basic.sh | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh
index 3de13daabe..49923c5ff1 100755
--- a/t/t0000-basic.sh
+++ b/t/t0000-basic.sh
@@ -1118,16 +1118,18 @@ P=$(test_oid root)
test_expect_success 'git commit-tree records the correct tree in a commit' '
commit0=$(echo NO | git commit-tree $P) &&
- git show --pretty=raw $commit0 >actual &&
- tree=$(sed -n -e "s/^tree //p" -e "/^author /q" actual) &&
- test "z$tree" = "z$P"
+ git show --pretty=raw $commit0 >output &&
+ echo "$P" >expect &&
+ sed -n -e "s/^tree //p" -e "/^author /q" output >actual &&
+ test_cmp expect actual
'
test_expect_success 'git commit-tree records the correct parent in a commit' '
commit1=$(echo NO | git commit-tree $P -p $commit0) &&
- git show --pretty=raw $commit1 >actual &&
- parent=$(sed -n -e "s/^parent //p" -e "/^author /q" actual) &&
- test "z$commit0" = "z$parent"
+ git show --pretty=raw $commit1 >output &&
+ echo "$commit0" >expect &&
+ sed -n -e "s/^parent //p" -e "/^author /q" output >actual &&
+ test_cmp expect actual
'
test_expect_success 'git commit-tree omits duplicated parent in a commit' '
--
2.21.0
next prev parent reply other threads:[~2019-03-30 14:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-30 14:27 [GSoC][PATCH v4 0/5] Avoid using pipes Jonathan Chang
2019-03-30 14:27 ` [GSoC][PATCH v4 1/5] t0000: fix indentation Jonathan Chang
2019-03-30 14:27 ` [GSoC][PATCH v4 2/5] t0000: avoid using pipes Jonathan Chang
2019-03-30 14:27 ` [GSoC][PATCH v4 3/5] t0000: use test_line_count instead of wc -l Jonathan Chang
2019-03-30 14:27 ` Jonathan Chang [this message]
2019-03-30 19:38 ` [GSoC][PATCH v4 4/5] t0000: use test_cmp instead of "test" builtin Thomas Gummerer
2019-03-31 5:17 ` jonathan chang
2019-03-31 18:57 ` Thomas Gummerer
2019-03-30 14:27 ` [GSoC][PATCH v4 5/5] t0000: make use of the test_must_be_empty function Jonathan Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=731463ed9892c283b6acb0ce69e097769e43de62.1553954776.git.ttjtftx@gmail.com \
--to=ttjtftx@gmail.com \
--cc=avarab@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=sunshine@sunshineco.com \
--cc=t.gummerer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).