From: Jonathan Tan <jonathantanmy@google.com>
To: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Cc: Stefan Beller <sbeller@google.com>
Subject: Re: What's cooking in git.git (Nov 2016, #05; Wed, 23)
Date: Mon, 28 Nov 2016 16:01:41 -0800 [thread overview]
Message-ID: <732c0e78-74b5-befa-e3c5-5ed9f221fa3a@google.com> (raw)
In-Reply-To: <xmqqk2btlr3x.fsf@gitster.mtv.corp.google.com>
On 11/23/2016 03:21 PM, Junio C Hamano wrote:
> * jt/use-trailer-api-in-commands (2016-11-02) 6 commits
> - sequencer: use trailer's trailer layout
> - trailer: have function to describe trailer layout
> - trailer: avoid unnecessary splitting on lines
> - commit: make ignore_non_trailer take buf/len
> - SQUASH???
> - trailer: be stricter in parsing separators
>
> Commands that operate on a log message and add lines to the trailer
> blocks, such as "format-patch -s", "cherry-pick (-x|-s)", and
> "commit -s", have been taught to use the logic of and share the
> code with "git interpret-trailer".
>
> What's the doneness of this topic?
Stefan Beller mentioned [1] that this seemed OK to him from a cursory
read. Do I need to look for another reviewer (or a more thorough review)?
[1] <CAGZ79kY8AUwOYAQX=PEHU3H+AhLAuxtC9+hb42da6TrSdz4BzA@mail.gmail.com>
next prev parent reply other threads:[~2016-11-29 0:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 23:21 What's cooking in git.git (Nov 2016, #05; Wed, 23) Junio C Hamano
2016-11-25 19:40 ` Jakub Narębski
2016-11-26 9:42 ` Duy Nguyen
2016-11-28 18:08 ` Junio C Hamano
2016-11-29 0:01 ` Jonathan Tan [this message]
2016-11-29 0:06 ` Junio C Hamano
2016-11-29 4:43 ` Jonathan Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=732c0e78-74b5-befa-e3c5-5ed9f221fa3a@google.com \
--to=jonathantanmy@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).