From: Johannes Sixt <j6t@kdbg.org>
To: Michael Montalbo <mmontalbo@gmail.com>,
Shlok Kulshreshtha <diy2903@gmail.com>
Cc: git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
"D . Ben Knoble" <ben.knoble@gmail.com>,
"René Scharfe" <l.s.r@web.de>,
"Eric Sunshine" <sunshine@sunshineco.com>,
"Scott L . Burson" <Scott@sympoiesis.com>
Subject: Re: [PATCH v2] userdiff: add support for Swift
Date: Mon, 27 Jul 2026 08:44:24 +0200 [thread overview]
Message-ID: <734cf745-ff32-4681-be2f-ad3225c80bec@kdbg.org> (raw)
In-Reply-To: <CAC2QwmK7HVma7HMxmXvC7qa4XQVomteC0x7PpX61MjpDLbvDzA@mail.gmail.com>
Am 27.07.26 um 07:03 schrieb Michael Montalbo:
> On Tue, Jul 21, 2026 at 12:06 AM Shlok Kulshreshtha <diy2903@gmail.com> wrote:
>>
>> Add a built-in userdiff driver for the Swift programming language so that
>> diff hunk headers and word diffs work out of the box for ".swift" files.
>>
>
> I noticed other languages add a test_language_driver entry to
> t/t4034-diff-words.sh with corresponding pre/post/expect
> fixtures. Should we add something similar for Swift?
We could that. But since the words are basically run-of-the-mill and
nothing exotic (like we had for the scheme driver), I gladly forgo a
test script at this time. In the past, these test scripts turned out to
be non-trivial to get correct and it was a burden for both the author
and the reviewers. It would certainly exceed the scope of a microproject.
-- Hannes
next prev parent reply other threads:[~2026-07-27 6:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 14:02 [PATCH] userdiff: add support for Swift Shlok Kulshreshtha
2026-07-17 16:27 ` Junio C Hamano
2026-07-18 18:11 ` Johannes Sixt
2026-07-20 4:55 ` Junio C Hamano
2026-07-20 8:49 ` Johannes Sixt
2026-07-20 9:52 ` Shlok Kulshreshtha
2026-07-21 6:57 ` [PATCH v2] " Shlok Kulshreshtha
2026-07-21 19:33 ` Junio C Hamano
2026-07-23 8:00 ` Johannes Sixt
2026-07-27 5:03 ` Michael Montalbo
2026-07-27 6:44 ` Johannes Sixt [this message]
2026-07-27 17:37 ` Michael Montalbo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=734cf745-ff32-4681-be2f-ad3225c80bec@kdbg.org \
--to=j6t@kdbg.org \
--cc=Scott@sympoiesis.com \
--cc=ben.knoble@gmail.com \
--cc=diy2903@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
--cc=mmontalbo@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox