From: Johannes Schindelin <johannes.schindelin@gmx.de>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH v2 4/4] gc: remove broken symrefs
Date: Mon, 28 Sep 2015 22:05:59 +0200 [thread overview]
Message-ID: <737df8378d1c83c97a53e5591a2a6ffb@dscho.org> (raw)
In-Reply-To: <20150928190332.GA17258@sigill.intra.peff.net>
Hi Peff,
On 2015-09-28 21:03, Jeff King wrote:
> On Mon, Sep 28, 2015 at 04:02:08PM +0200, Johannes Schindelin wrote:
>
>> @@ -136,7 +139,14 @@ int cmd_prune(int argc, const char **argv, const char *prefix)
>> if (show_progress)
>> progress = start_progress_delay(_("Checking connectivity"), 0, 0, 2);
>>
>> - mark_reachable_objects(&revs, 1, expire, progress, NULL);
>> + revs.ignore_missing = 1;
>> + mark_reachable_objects(&revs, 1, expire, progress, &broken_symrefs);
>
> You should not need this ignore_missing anymore, right?
>
> It is the dangerous thing I mentioned earlier, but I am puzzled why it
> does not cause t5312 to fail.
Gaaaaaah! I edited this out at least twice, yet it creeps back in. Bah!
Junio, would you mind fixing this up locally? If you want me to submit v3, just let me know, I will take care of it tomorrow.
Ciao,
Dscho
next prev parent reply other threads:[~2015-09-28 20:06 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-24 9:13 [PATCH 0/4] Fix gc failure when a remote HEAD goes stale Johannes Schindelin
2015-09-24 9:13 ` [PATCH 1/4] gc: demonstrate failure with stale remote HEAD Johannes Schindelin
2015-09-24 9:13 ` [PATCH 2/4] pack-objects: do not get distracted by stale refs Johannes Schindelin
2015-09-24 17:03 ` Jeff King
2015-09-24 9:13 ` [PATCH 3/4] mark_reachable_objects(): optionally collect broken refs Johannes Schindelin
2015-09-24 17:56 ` Jeff King
2015-09-24 9:14 ` [PATCH 4/4] gc: remove " Johannes Schindelin
2015-09-24 17:57 ` Jeff King
2015-09-25 0:08 ` Junio C Hamano
2015-09-25 1:35 ` Jeff King
2015-09-28 14:01 ` [PATCH v2 0/4] Fix gc failure when a remote HEAD goes stale Johannes Schindelin
2015-09-28 14:01 ` [PATCH v2 1/4] gc: demonstrate failure with stale remote HEAD Johannes Schindelin
2015-09-28 14:01 ` [PATCH v2 2/4] pack-objects: do not get distracted by broken symrefs Johannes Schindelin
2015-09-28 14:01 ` [PATCH v2 3/4] mark_reachable_objects(): optionally collect " Johannes Schindelin
2015-09-28 14:02 ` [PATCH v2 4/4] gc: remove " Johannes Schindelin
2015-09-28 18:41 ` Junio C Hamano
2015-09-28 18:49 ` Junio C Hamano
2015-09-28 19:58 ` Johannes Schindelin
2015-10-05 22:06 ` Junio C Hamano
2015-09-28 19:03 ` Jeff King
2015-09-28 20:05 ` Johannes Schindelin [this message]
2015-10-06 13:57 ` [PATCH v3 0/2] Fix gc failure when a remote HEAD goes stale Johannes Schindelin
2015-10-06 13:58 ` [PATCH v3 1/2] gc: demonstrate failure with stale remote HEAD Johannes Schindelin
2015-10-06 13:59 ` [PATCH v3 2/2] pack-objects: do not get distracted by broken symrefs Johannes Schindelin
2015-10-07 17:45 ` Junio C Hamano
2015-10-08 19:15 ` Johannes Schindelin
2015-10-08 19:42 ` Junio C Hamano
2015-10-08 20:10 ` Johannes Schindelin
-- strict thread matches above, loose matches on Subject: below --
2015-10-06 13:59 [PATCH v2 4/4] gc: remove " Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=737df8378d1c83c97a53e5591a2a6ffb@dscho.org \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).