From: Matthieu Moy <matthieu.moy@univ-lyon1.fr>
To: Todd Zullinger <tmz@pobox.com>
Cc: git <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH] t3701: update tests fixed with builtin add -p
Date: Tue, 14 Jun 2022 23:34:27 +0200 (CEST) [thread overview]
Message-ID: <739656227.13381886.1655242467295.JavaMail.zimbra@inria.fr> (raw)
In-Reply-To: <0aff4d49e5934d11870a3c6bfecf1af0@SAMBXP02.univ-lyon1.fr>
"Todd Zullinger" <tmz@pobox.com> wrote:
>
> -test_expect_failure 'split hunk "add -p (no, yes, edit)"' '
> +test_expect_success 'split hunk "add -p (no, yes, edit)"' '
> test_write_lines 5 10 20 21 30 31 40 50 60 >test &&
> git reset &&
> # test sequence is s(plit), n(o), y(es), e(dit)
> @@ -562,7 +562,7 @@ test_expect_success 'split hunk with incomplete line at end'
> '
> test_must_fail git grep --cached before
> '
>
> -test_expect_failure 'edit, adding lines to the first hunk' '
> +test_expect_success 'edit, adding lines to the first hunk' '
The magic of open-source: find a bug, write a test, try to fix the bug, give up, and wait for someone else to do it :-).
Thanks!
--
Matthieu Moy
https://matthieu-moy.fr/
next prev parent reply other threads:[~2022-06-14 21:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 1:46 [ANNOUNCE] Git v2.37.0-rc0 Junio C Hamano
2022-06-14 15:00 ` Derrick Stolee
2022-06-14 18:52 ` [PATCH] t3701: update tests fixed with builtin add -p Todd Zullinger
[not found] ` <0aff4d49e5934d11870a3c6bfecf1af0@SAMBXP02.univ-lyon1.fr>
2022-06-14 21:34 ` Matthieu Moy [this message]
2022-06-16 14:05 ` [ANNOUNCE] Git v2.37.0-rc0 Matthew John Cheetham
2022-06-16 18:13 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=739656227.13381886.1655242467295.JavaMail.zimbra@inria.fr \
--to=matthieu.moy@univ-lyon1.fr \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=tmz@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).