git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Rubén Justo" <rjusto@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git List <git@vger.kernel.org>, Jeff King <peff@peff.net>,
	Johannes Sixt <j6t@kdbg.org>
Subject: Re: [PATCH] pager: die when paging to non-existing command
Date: Thu, 20 Jun 2024 22:22:30 +0200	[thread overview]
Message-ID: <73b9a923-c3d6-46e8-b050-e8a93b9757a2@gmail.com> (raw)
In-Reply-To: <xmqqsex7tp0c.fsf@gitster.g>

On Thu, Jun 20, 2024 at 12:04:03PM -0700, Junio C Hamano wrote:

> > +		die("unable to start the pager: '%s'", pager);
> 
> If this error string is not used elsewhere, it probably is a good
> idea to "revert" to the original error message lost by ea27a18c,
> which was:
> 
> 		die("unable to execute pager '%s'", pager);

Makes sense.  Let me know if you need me to reroll.

> Just in case there is a reason why we should instead silently return
> on MinGW, I'll Cc the author of bfdd9ffd, though.

Yup.  I did notice the MINGW conditions in t7006 but, to be honest, I
hadn't thought about this.  Thank you for considering it and seeking
confirmation.

  reply	other threads:[~2024-06-20 20:22 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-20 17:25 [PATCH] pager: die when paging to non-existing command Rubén Justo
2024-06-20 19:04 ` Junio C Hamano
2024-06-20 20:22   ` Rubén Justo [this message]
2024-06-20 21:03     ` Junio C Hamano
2024-06-20 22:17   ` Johannes Sixt
2024-06-20 22:35     ` Junio C Hamano
2024-06-21  6:51       ` Jeff King
2024-06-21 17:11       ` Dragan Simic
2024-06-24  7:35     ` Johannes Schindelin
2024-06-21 11:28   ` Phillip Wood
2024-06-21 23:21     ` Junio C Hamano
2024-06-21  6:40 ` Jeff King
2024-06-21 21:11   ` Rubén Justo
2024-06-21 21:29 ` [PATCH v2] " Rubén Justo
2024-06-21 23:31   ` [PATCH v3] " Rubén Justo
2024-06-22  7:08     ` Johannes Sixt
2024-06-23  7:09     ` [PATCH v4] " Rubén Justo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=73b9a923-c3d6-46e8-b050-e8a93b9757a2@gmail.com \
    --to=rjusto@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=j6t@kdbg.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).