git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Rast <trast@inf.ethz.ch>
To: <git@vger.kernel.org>
Cc: Jens Lehmann <Jens.Lehmann@web.de>
Subject: [PATCH 1/4] coverage: split build target into compile and test
Date: Mon, 13 May 2013 23:27:25 +0200	[thread overview]
Message-ID: <74a63334c1b7cd4c5bb43050dce256e125ca8c8b.1368479988.git.trast@inf.ethz.ch> (raw)
In-Reply-To: <cover.1368479988.git.trast@inf.ethz.ch>

Confusingly, the coverage-build target in fact builds with gcov
support _and runs tests_.

Split it into two targets that actually are named after what they do.

Signed-off-by: Thomas Rast <trast@inf.ethz.ch>
---
 Makefile | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/Makefile b/Makefile
index 0f931a2..f98296b 100644
--- a/Makefile
+++ b/Makefile
@@ -2524,10 +2524,10 @@ check-builtins::
 
 ### Test suite coverage testing
 #
-.PHONY: coverage coverage-clean coverage-build coverage-report
+.PHONY: coverage coverage-clean coverage-compile coverage-test coverage-report
 
 coverage:
-	$(MAKE) coverage-build
+	$(MAKE) coverage-test
 	$(MAKE) coverage-report
 
 object_dirs := $(sort $(dir $(OBJECTS)))
@@ -2543,8 +2543,10 @@ COVERAGE_CFLAGS = $(CFLAGS) -O0 -ftest-coverage -fprofile-arcs
 COVERAGE_LDFLAGS = $(CFLAGS)  -O0 -lgcov
 GCOVFLAGS = --preserve-paths --branch-probabilities --all-blocks
 
-coverage-build: coverage-clean
+coverage-compile:
 	$(MAKE) CFLAGS="$(COVERAGE_CFLAGS)" LDFLAGS="$(COVERAGE_LDFLAGS)" all
+
+coverage-test: coverage-clean-results coverage-compile
 	$(MAKE) CFLAGS="$(COVERAGE_CFLAGS)" LDFLAGS="$(COVERAGE_LDFLAGS)" \
 		-j1 test
 
-- 
1.8.3.rc1.400.g07d6e4a

  reply	other threads:[~2013-05-13 21:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-13 21:27 [PATCH 0/4] Coverage support revisited Thomas Rast
2013-05-13 21:27 ` Thomas Rast [this message]
2013-05-13 21:27 ` [PATCH 2/4] coverage: do not delete .gcno files before building Thomas Rast
2013-05-13 21:27 ` [PATCH 3/4] coverage: set DEFAULT_TEST_TARGET to avoid using prove Thomas Rast
2013-05-13 21:27 ` [PATCH 4/4] coverage: build coverage-untested-functions by default Thomas Rast
2013-05-13 22:14 ` [PATCH 0/4] Coverage support revisited Junio C Hamano
2013-05-13 22:33 ` Jens Lehmann
2013-05-14  9:14   ` Thomas Rast

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74a63334c1b7cd4c5bb43050dce256e125ca8c8b.1368479988.git.trast@inf.ethz.ch \
    --to=trast@inf.ethz.ch \
    --cc=Jens.Lehmann@web.de \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).