From: Markus Elfring <Markus.Elfring@web.de>
To: "Gábor Szeder" <szeder.dev@gmail.com>
Cc: "Martin Ågren" <martin.agren@gmail.com>,
git@vger.kernel.org, "Denton Liu" <liu.denton@gmail.com>
Subject: Re: coccinelle: merge two rules from flex_alloc.cocci
Date: Thu, 14 Nov 2019 18:30:24 +0100 [thread overview]
Message-ID: <751e4cc2-e6d0-edfb-b206-4204443a5c62@web.de> (raw)
In-Reply-To: <20191114163527.GT4348@szeder.dev>
>> Does any test infrastructure (or benchmarks) exist which you would trust for
>> corresponding comparisons of software run time characteristics?
>
> Yes, just run:
>
> make cocciclean
> time make contrib/coccinelle/flex_alloc.cocci.patch
Thanks for this suggestion.
> before and after your changes, and include the timing results in the
> commit message if there is a notable difference.
The measurements from my test system might not be representative enough.
> FWIW, I did just that with your "coccinelle: merge twelve rules from
> object_id.cocci" patch [1], and the runtime went down from 2m48.610 to
> 2m34.395, a bit over 8% speedup. (with Ubuntu 16.04's Coccinelle
> 1.0.4)
>
>
> [1] https://public-inbox.org/git/6c9962c0-67c1-e700-c145-793ce6498099@web.de/
These numbers seem to be nice.
Would a direct reply have been more helpful for the referenced patch
than the current subject?
Regards,
Markus
next prev parent reply other threads:[~2019-11-14 17:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 15:34 [PATCH] coccinelle: merge two rules from flex_alloc.cocci Markus Elfring
2019-11-12 17:59 ` Denton Liu
2019-11-13 18:27 ` Martin Ågren
2019-11-13 21:10 ` Markus Elfring
2019-11-14 6:37 ` Martin Ågren
2019-11-14 8:15 ` Markus Elfring
2019-11-14 16:35 ` SZEDER Gábor
2019-11-14 17:30 ` Markus Elfring [this message]
2019-11-15 5:13 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=751e4cc2-e6d0-edfb-b206-4204443a5c62@web.de \
--to=markus.elfring@web.de \
--cc=git@vger.kernel.org \
--cc=liu.denton@gmail.com \
--cc=martin.agren@gmail.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).