* [PATCH] test-drop-caches: mark file local symbols with static
@ 2017-09-17 16:14 Ramsay Jones
2017-09-18 12:32 ` Ben Peart
0 siblings, 1 reply; 2+ messages in thread
From: Ramsay Jones @ 2017-09-17 16:14 UTC (permalink / raw)
To: benpeart; +Cc: Junio C Hamano, GIT Mailing-list
Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
Hi Ben,
If you need to re-roll your 'bp/fsmonitor' branch, could you please
squash this into the relevant patch (commit c6b5a28941, "fsmonitor:
add a performance test", 15-09-2017).
Thanks!
ATB,
Ramsay Jones
t/helper/test-drop-caches.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/t/helper/test-drop-caches.c b/t/helper/test-drop-caches.c
index 717079865..17590170f 100644
--- a/t/helper/test-drop-caches.c
+++ b/t/helper/test-drop-caches.c
@@ -2,7 +2,7 @@
#if defined(GIT_WINDOWS_NATIVE)
-int cmd_sync(void)
+static int cmd_sync(void)
{
char Buffer[MAX_PATH];
DWORD dwRet;
@@ -49,7 +49,7 @@ typedef enum _SYSTEM_MEMORY_LIST_COMMAND {
MemoryCommandMax
} SYSTEM_MEMORY_LIST_COMMAND;
-BOOL GetPrivilege(HANDLE TokenHandle, LPCSTR lpName, int flags)
+static BOOL GetPrivilege(HANDLE TokenHandle, LPCSTR lpName, int flags)
{
BOOL bResult;
DWORD dwBufferLength;
@@ -77,7 +77,7 @@ BOOL GetPrivilege(HANDLE TokenHandle, LPCSTR lpName, int flags)
return bResult;
}
-int cmd_dropcaches(void)
+static int cmd_dropcaches(void)
{
HANDLE hProcess = GetCurrentProcess();
HANDLE hToken;
@@ -118,36 +118,36 @@ int cmd_dropcaches(void)
#elif defined(__linux__)
-int cmd_sync(void)
+static int cmd_sync(void)
{
return system("sync");
}
-int cmd_dropcaches(void)
+static int cmd_dropcaches(void)
{
return system("echo 3 | sudo tee /proc/sys/vm/drop_caches");
}
#elif defined(__APPLE__)
-int cmd_sync(void)
+static int cmd_sync(void)
{
return system("sync");
}
-int cmd_dropcaches(void)
+static int cmd_dropcaches(void)
{
return system("sudo purge");
}
#else
-int cmd_sync(void)
+static int cmd_sync(void)
{
return 0;
}
-int cmd_dropcaches(void)
+static int cmd_dropcaches(void)
{
return error("drop caches not implemented on this platform");
}
--
2.14.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] test-drop-caches: mark file local symbols with static
2017-09-17 16:14 [PATCH] test-drop-caches: mark file local symbols with static Ramsay Jones
@ 2017-09-18 12:32 ` Ben Peart
0 siblings, 0 replies; 2+ messages in thread
From: Ben Peart @ 2017-09-18 12:32 UTC (permalink / raw)
To: Ramsay Jones, benpeart; +Cc: Junio C Hamano, GIT Mailing-list
On 9/17/2017 12:14 PM, Ramsay Jones wrote:
>
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Ben,
>
> If you need to re-roll your 'bp/fsmonitor' branch, could you please
> squash this into the relevant patch (commit c6b5a28941, "fsmonitor:
> add a performance test", 15-09-2017).
Absolutely. Thanks!
I'd really appreciate some feedback on whether this works properly on
platform other than Windows.
>
> Thanks!
>
> ATB,
> Ramsay Jones
>
> t/helper/test-drop-caches.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/t/helper/test-drop-caches.c b/t/helper/test-drop-caches.c
> index 717079865..17590170f 100644
> --- a/t/helper/test-drop-caches.c
> +++ b/t/helper/test-drop-caches.c
> @@ -2,7 +2,7 @@
>
> #if defined(GIT_WINDOWS_NATIVE)
>
> -int cmd_sync(void)
> +static int cmd_sync(void)
> {
> char Buffer[MAX_PATH];
> DWORD dwRet;
> @@ -49,7 +49,7 @@ typedef enum _SYSTEM_MEMORY_LIST_COMMAND {
> MemoryCommandMax
> } SYSTEM_MEMORY_LIST_COMMAND;
>
> -BOOL GetPrivilege(HANDLE TokenHandle, LPCSTR lpName, int flags)
> +static BOOL GetPrivilege(HANDLE TokenHandle, LPCSTR lpName, int flags)
> {
> BOOL bResult;
> DWORD dwBufferLength;
> @@ -77,7 +77,7 @@ BOOL GetPrivilege(HANDLE TokenHandle, LPCSTR lpName, int flags)
> return bResult;
> }
>
> -int cmd_dropcaches(void)
> +static int cmd_dropcaches(void)
> {
> HANDLE hProcess = GetCurrentProcess();
> HANDLE hToken;
> @@ -118,36 +118,36 @@ int cmd_dropcaches(void)
>
> #elif defined(__linux__)
>
> -int cmd_sync(void)
> +static int cmd_sync(void)
> {
> return system("sync");
> }
>
> -int cmd_dropcaches(void)
> +static int cmd_dropcaches(void)
> {
> return system("echo 3 | sudo tee /proc/sys/vm/drop_caches");
> }
>
> #elif defined(__APPLE__)
>
> -int cmd_sync(void)
> +static int cmd_sync(void)
> {
> return system("sync");
> }
>
> -int cmd_dropcaches(void)
> +static int cmd_dropcaches(void)
> {
> return system("sudo purge");
> }
>
> #else
>
> -int cmd_sync(void)
> +static int cmd_sync(void)
> {
> return 0;
> }
>
> -int cmd_dropcaches(void)
> +static int cmd_dropcaches(void)
> {
> return error("drop caches not implemented on this platform");
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-18 12:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-17 16:14 [PATCH] test-drop-caches: mark file local symbols with static Ramsay Jones
2017-09-18 12:32 ` Ben Peart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).