From: "Kristoffer Haugsbakk" <code@khaugsbakk.name>
To: "Josh Soref" <gitgitgadget@gmail.com>
Cc: "Harmen Stoppels" <me@harmenstoppels.nl>, git@vger.kernel.org
Subject: Re: [PATCH v2] rebase: make warning less passive aggressive
Date: Thu, 22 Feb 2024 11:53:10 +0100 [thread overview]
Message-ID: <759cbb30-96dd-456a-baab-b9451d400dcb@app.fastmail.com> (raw)
In-Reply-To: <pull.1669.v2.git.1708537097448.gitgitgadget@gmail.com>
On Wed, Feb 21, 2024, at 18:38, Harmen Stoppels via GitGitGadget wrote:
> From: Harmen Stoppels <me@harmenstoppels.nl>
>
> When you run `git rebase --continue` when no rebase is in progress, git
> outputs `fatal: No rebase in progress?` which is not a question but a
> statement. Make it appear as a statement, and use lowercase to align
> with error message style.
>
> Signed-off-by: Harmen Stoppels <me@harmenstoppels.nl>
> ---
I’ve interpreted this error as: I’m not quite sure but it looks like you
are not in the middle of a rebase? Like it can’t be completely
sure. Maybe from a more “primitive” time, implementation-wise?[1] :)
(I waited to make this reply in order to see what others would say. And
apparently there is no need for a hedging/passive aggressive question
mark.)
† 1: 031321c654d (Add --continue and --abort options to git-rebase.,
2006-04-26)
--
Kristoffer Haugsbakk
next prev parent reply other threads:[~2024-02-22 10:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 15:23 [PATCH] rebase: make warning less passive aggressive Harmen Stoppels via GitGitGadget
2024-02-20 17:29 ` Junio C Hamano
2024-02-21 17:38 ` Michal Suchánek
2024-02-21 17:56 ` Junio C Hamano
2024-02-21 18:02 ` Junio C Hamano
2024-02-21 18:30 ` Michal Suchánek
2024-02-21 22:05 ` Jean-Noël AVILA
2024-02-21 22:46 ` Junio C Hamano
2024-02-22 1:43 ` Junio C Hamano
2024-02-22 10:01 ` Jean-Noël AVILA
2024-02-22 11:04 ` Michal Suchánek
2024-02-22 16:46 ` Junio C Hamano
2024-02-21 7:14 ` Patrick Steinhardt
2024-02-21 17:31 ` Junio C Hamano
2024-02-21 17:38 ` [PATCH v2] " Harmen Stoppels via GitGitGadget
2024-02-22 8:15 ` Patrick Steinhardt
2024-02-22 10:53 ` Kristoffer Haugsbakk [this message]
2024-02-22 17:00 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=759cbb30-96dd-456a-baab-b9451d400dcb@app.fastmail.com \
--to=code@khaugsbakk.name \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=me@harmenstoppels.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).