From: Jeff Hostetler <git@jeffhostetler.com>
To: Todd Zullinger <tmz@pobox.com>
Cc: git@vger.kernel.org, gitster@pobox.com, peff@peff.net,
Jeff Hostetler <jeffhost@microsoft.com>
Subject: Re: [PATCH v7 2/2] json-writer: t0019: add Python unit test
Date: Wed, 6 Jun 2018 17:05:59 -0400 [thread overview]
Message-ID: <75fc23f9-5a76-a4fc-9135-881a4e317408@jeffhostetler.com> (raw)
In-Reply-To: <20180606171052.GI3094@zaya.teonanacatl.net>
On 6/6/2018 1:10 PM, Todd Zullinger wrote:
> git@jeffhostetler.com wrote:
>> +# As a sanity check, ask Python to parse our generated JSON. Let Python
>> +# recursively dump the resulting dictionary in sorted order. Confirm that
>> +# that matches our expectations.
>> +test_expect_success PYTHON 'parse JSON using Python' '
> [...]
>> + python "$TEST_DIRECTORY"/t0019/parse_json_1.py <output.json >actual &&
>
> Would this be better using $PYTHON_PATH rather than
> hard-coding python as the command?
>
good catch!
thanks
Jeff
prev parent reply other threads:[~2018-06-06 21:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-05 16:33 [PATCH v7 0/2] json-writer V7 git
2018-06-05 16:33 ` [PATCH v7 1/2] json_writer: new routines to create data in JSON format git
2018-06-05 16:33 ` [PATCH v7 2/2] json-writer: t0019: add Python unit test git
2018-06-06 17:10 ` Todd Zullinger
2018-06-06 21:03 ` Jeff King
2018-06-06 21:11 ` Jeff Hostetler
2018-06-07 0:16 ` Ramsay Jones
2018-06-07 1:49 ` Todd Zullinger
2018-06-07 2:38 ` Jeff King
2018-06-07 2:23 ` Jeff King
2018-06-07 2:49 ` Jeff King
2018-06-07 19:03 ` Ramsay Jones
2018-06-06 21:05 ` Jeff Hostetler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75fc23f9-5a76-a4fc-9135-881a4e317408@jeffhostetler.com \
--to=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jeffhost@microsoft.com \
--cc=peff@peff.net \
--cc=tmz@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).