git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jay Soffian" <jaysoffian+git@gmail.com>
To: "Johannes Schindelin" <Johannes.Schindelin@gmx.de>
Cc: "Jeff King" <peff@peff.net>, "Junio C Hamano" <gitster@pobox.com>,
	"Johannes Sixt" <j.sixt@viscovery.net>,
	git@vger.kernel.org, "Lars Hjemli" <hjemli@gmail.com>
Subject: Re: [PATCH] allow setting GIT_WORK_TREE to "no work tree"
Date: Thu, 7 Feb 2008 13:06:46 -0500	[thread overview]
Message-ID: <76718490802071006j9eaa4bctedc18f4a62e2b91c@mail.gmail.com> (raw)
In-Reply-To: <alpine.LSU.1.00.0802071231540.8543@racer.site>

On Feb 7, 2008 7:33 AM, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
>
> On Thu, 7 Feb 2008, Jay Soffian wrote:
>
> > Is using something like "__GIT_WORK_TREE_NOT_SET__" that terrible?
>
> Yes.  First: it looks more like a C constant than a proper environment
> variable.  Second: what to do _sanely_, when both GIT_WORK_TREE and
> GIT_WORK_TREE_NOT_SET are true?

Sorry I was unclear. The discussion was about using a special value to
denote "this is not set." So I meant something like:

GIT_WORK_TREE="__GIT_WORK_TREE_NOT_SET"

There may not be precedent in git, but it is not unusual to use a
double-underbar prefix to denote private names and/or values. While in
theory a user could have a directory named as such, it would seem
highly unlikely. This looks a little cleaner to me than using ":", "
", or "/dev/null".

j.

  reply	other threads:[~2008-02-07 18:07 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-06 10:26 [PATCH] allow setting GIT_WORK_TREE to "no work tree" Jeff King
2008-02-06 10:42 ` Johannes Sixt
2008-02-06 11:01   ` Jeff King
2008-02-06 20:54     ` Junio C Hamano
2008-02-06 20:59       ` Junio C Hamano
2008-02-07  5:13         ` Jeff King
2008-02-07  7:13           ` Jay Soffian
2008-02-07 12:33             ` Johannes Schindelin
2008-02-07 18:06               ` Jay Soffian [this message]
2008-02-07  9:10           ` Junio C Hamano
2008-02-07 19:02   ` Johannes Schindelin
2008-02-08  7:21     ` Johannes Sixt
2008-02-08 12:05       ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=76718490802071006j9eaa4bctedc18f4a62e2b91c@mail.gmail.com \
    --to=jaysoffian+git@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=hjemli@gmail.com \
    --cc=j.sixt@viscovery.net \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).