From: "Jay Soffian" <jaysoffian+git@gmail.com>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-web--browse: improve browser support under OS X
Date: Mon, 11 Feb 2008 09:15:23 -0500 [thread overview]
Message-ID: <76718490802110615j3017e17awcae2a04087984f0d@mail.gmail.com> (raw)
In-Reply-To: <7vve4wb3h7.fsf@gitster.siamese.dyndns.org>
On Feb 10, 2008 10:01 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Because we preprocess git-web--browse.sh to create the final
> git-web--browse to be installed, something like "open" that is
> not a user but a platform preference might be better done as a
> build-time thing, instead of forcing everybody to spawn "uname",
> perhaps like this?
Seems like overkill (over the original patch), but honestly, I'm happy
with whatever solution deemed appropriate, just as long as I can use
my native browser on OS X. :-)
> Also I wonder why the check for SECURITYSESSIONID your original
> had is not good enough for this Mac specific customization?
Well, I thought it was. I was just responding to feedback. I don't
have enough experience with the git project to have much of an opinion
either way.
Anyway, thanks for the pointers.
j.
next prev parent reply other threads:[~2008-02-11 14:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-08 21:23 [PATCH] Improve git-help--browse browser support under OS X jaysoffian+git
2008-02-09 20:20 ` Dmitry Potapov
2008-02-10 2:15 ` Jay Soffian
2008-02-10 12:43 ` Dmitry Potapov
2008-02-10 13:45 ` Christian Couder
2008-02-11 2:13 ` Jay Soffian
2008-02-11 5:03 ` Christian Couder
2008-02-11 2:10 ` Jay Soffian
2008-02-11 2:24 ` [PATCH] git-web--browse: improve " jaysoffian+git
2008-02-11 3:01 ` Junio C Hamano
2008-02-11 14:15 ` Jay Soffian [this message]
2008-02-12 16:40 ` Jay Soffian
2008-02-13 6:55 ` Christian Couder
2008-02-13 22:14 ` Junio C Hamano
2008-02-13 22:46 ` Pieter de Bie
2008-02-14 0:13 ` Jay Soffian
2008-02-14 5:09 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76718490802110615j3017e17awcae2a04087984f0d@mail.gmail.com \
--to=jaysoffian+git@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).