From: "Jay Soffian" <jaysoffian@gmail.com>
To: "Johannes Schindelin" <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] test mailinfo rfc3676 support
Date: Fri, 15 Feb 2008 11:44:24 -0500 [thread overview]
Message-ID: <76718490802150844w7cc583b7v4d3480ed43de5cd1@mail.gmail.com> (raw)
In-Reply-To: <alpine.LSU.1.00.0802151058270.30505@racer.site>
On Fri, Feb 15, 2008 at 6:01 AM, Johannes Schindelin
<Johannes.Schindelin@gmx.de> wrote:
> Hmm. Such a corrupt patch (lacking spaces at the beginning of the line)
> would not be accepted by git-apply. I briefly thought about teaching
> git-apply to grok that, with a flag. But now I think that mailsplit
> should handle that, no?
>
> Question is: can you "de-corruptify" such a patch? (Note: it would
> probably need a validating step, too, i.e. count the lines it added a
> space to, and match that up with the numbers in the @@ lines)
Heh, I see this was a confusing patch. It is a lot clearer to read if
you apply it and then take a look at what's added to sample.mbox, as
well as look at the new files in t5100.
What I did to create this test was add the format=flowed code to
mailinfo (my previous patch email), extract it with format-patch, then
cut/paste it into my MUA and mail it to myself so I could have a sample
format=flowed message. I then added that to the sample.mbox to see if
the code I'd just added to mailinfo was working properly. Yes, it
"de-corrupted" it just fine by removing the flowing.
j.
next prev parent reply other threads:[~2008-02-15 16:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-15 2:21 [PATCH 1/2] mailinfo: support rfc3676 (format=flowed) text/plain messages Jay Soffian
2008-02-15 2:21 ` [PATCH 2/2] test mailinfo rfc3676 support Jay Soffian
2008-02-15 11:01 ` Johannes Schindelin
2008-02-15 16:44 ` Jay Soffian [this message]
2008-02-15 10:41 ` [PATCH 1/2] mailinfo: support rfc3676 (format=flowed) text/plain messages Johannes Schindelin
2008-02-15 16:35 ` Jay Soffian
2008-02-15 18:43 ` Jay Soffian
2008-02-16 2:30 ` Johannes Schindelin
2008-02-15 17:10 ` Junio C Hamano
2008-02-15 18:37 ` Jay Soffian
2008-02-16 6:57 ` Junio C Hamano
2008-02-16 7:43 ` Jay Soffian
2008-02-16 9:59 ` Junio C Hamano
2008-02-16 14:34 ` Derek Fawcus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76718490802150844w7cc583b7v4d3480ed43de5cd1@mail.gmail.com \
--to=jaysoffian@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).