From: "Jay Soffian" <jaysoffian@gmail.com>
To: "Johannes Schindelin" <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] mailinfo: support rfc3676 (format=flowed) text/plain messages
Date: Fri, 15 Feb 2008 13:43:03 -0500 [thread overview]
Message-ID: <76718490802151043q56340ea9i247dbb1601f8d225@mail.gmail.com> (raw)
In-Reply-To: <alpine.LSU.1.00.0802151035100.30505@racer.site>
On Fri, Feb 15, 2008 at 5:41 AM, Johannes Schindelin
<Johannes.Schindelin@gmx.de> wrote:
> > + char *cp = line;
> > + while (*cp == '>' && *cp != 0)
> > + cp++;
>
> How about using strchrnul()?
Actually strchrnul() here isn't correct. I want to strip leading '>'
only. strchrnul() will search for the first occurrence (skipping over
non-'>' to do so), which is not what I want.
> > + while (*cp != '\n' && *cp !=0)
> > + cp++;
>
> Again, this is the job for strchrnul().
Yep, here strchrnul would be fine.
j.
next prev parent reply other threads:[~2008-02-15 18:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-15 2:21 [PATCH 1/2] mailinfo: support rfc3676 (format=flowed) text/plain messages Jay Soffian
2008-02-15 2:21 ` [PATCH 2/2] test mailinfo rfc3676 support Jay Soffian
2008-02-15 11:01 ` Johannes Schindelin
2008-02-15 16:44 ` Jay Soffian
2008-02-15 10:41 ` [PATCH 1/2] mailinfo: support rfc3676 (format=flowed) text/plain messages Johannes Schindelin
2008-02-15 16:35 ` Jay Soffian
2008-02-15 18:43 ` Jay Soffian [this message]
2008-02-16 2:30 ` Johannes Schindelin
2008-02-15 17:10 ` Junio C Hamano
2008-02-15 18:37 ` Jay Soffian
2008-02-16 6:57 ` Junio C Hamano
2008-02-16 7:43 ` Jay Soffian
2008-02-16 9:59 ` Junio C Hamano
2008-02-16 14:34 ` Derek Fawcus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76718490802151043q56340ea9i247dbb1601f8d225@mail.gmail.com \
--to=jaysoffian@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).