From: "Jay Soffian" <jaysoffian@gmail.com>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: git@vger.kernel.org, "Johannes Schindelin" <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH 1/3] mailinfo: ensure handle_filter gets only one line at a time
Date: Sat, 16 Feb 2008 01:51:45 -0500 [thread overview]
Message-ID: <76718490802152251x20102ecep383fb76ce0c96b64@mail.gmail.com> (raw)
In-Reply-To: <7vmyq1e86n.fsf@gitster.siamese.dyndns.org>
On Feb 16, 2008 1:17 AM, Junio C Hamano <gitster@pobox.com> wrote:
> "Jay Soffian" <jaysoffian@gmail.com> writes:
>
> > On Feb 15, 2008 6:24 PM, Junio C Hamano <gitster@pobox.com> wrote:
> >> Care to provide a test case for this one?
> >
> > I'll see what I can do. I'm not sure it makes a difference...
>
> Of course it does; otherwise I wouldn't have asked.
What I meant was, I wasn't sure if the output of mailinfo
would have been incorrect w/o the patch. I noticed it only
when I added the format=flowed code which relied on
handle_filter() getting a single line at a time. I hadn't
looked at whether handle_commit_msg() and/or handle_patch()
(downstream of handle_filter) would care.
I wasn't trying to shirk off adding a test case. :-)
j.
prev parent reply other threads:[~2008-02-16 6:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-15 21:53 [PATCH 1/3] mailinfo: ensure handle_filter gets only one line at a time Jay Soffian
2008-02-15 21:53 ` [PATCH 2/3] mailinfo: support rfc3676 (format=flowed) text/plain messages Jay Soffian
2008-02-15 21:53 ` [PATCH 3/3] test mailinfo rfc3676 support Jay Soffian
2008-02-15 23:24 ` [PATCH 1/3] mailinfo: ensure handle_filter gets only one line at a time Junio C Hamano
2008-02-15 23:37 ` Jay Soffian
2008-02-16 6:17 ` Junio C Hamano
2008-02-16 6:22 ` Junio C Hamano
2008-02-16 6:51 ` Jay Soffian [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76718490802152251x20102ecep383fb76ce0c96b64@mail.gmail.com \
--to=jaysoffian@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).