From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jay Soffian" <jaysoffian@gmail.com>
Subject: Re: [PATCH] change Perl syntax to support Perl 5.6
Date: Sun, 31 Aug 2008 21:52:20 -0400
Message-ID: <76718490808311852n6d6d138ch7bbf5605c6cf7c18@mail.gmail.com>
References: <20080830173947.GF7185@schiele.dyndns.org>
	 <20080830183413.GG7185@schiele.dyndns.org>
	 <20080830183949.GA16415@coredump.intra.peff.net>
	 <200808302237.17017.jnareb@gmail.com>
	 <32541b130808302235g6a23efcfs78efe2ef557cd9c7@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: "Jakub Narebski" <jnareb@gmail.com>, "Jeff King" <peff@peff.net>,
	"Robert Schiele" <rschiele@gmail.com>,
	"Junio C Hamano" <gitster@pobox.com>, git@vger.kernel.org,
	"Lea Wiemann" <lewiemann@gmail.com>
To: "Avery Pennarun" <apenwarr@gmail.com>
X-From: git-owner@vger.kernel.org Mon Sep 01 03:53:27 2008
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git-2@gmane.org
Received: from vger.kernel.org ([209.132.176.167])
	by lo.gmane.org with esmtp (Exim 4.50)
	id 1KZybe-0003hi-SL
	for gcvg-git-2@gmane.org; Mon, 01 Sep 2008 03:53:27 +0200
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753035AbYIABwW (ORCPT <rfc822;gcvg-git-2@m.gmane.org>);
	Sun, 31 Aug 2008 21:52:22 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752994AbYIABwW
	(ORCPT <rfc822;git-outgoing>); Sun, 31 Aug 2008 21:52:22 -0400
Received: from yx-out-2324.google.com ([74.125.44.28]:59898 "EHLO
	yx-out-2324.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751911AbYIABwV (ORCPT <rfc822;git@vger.kernel.org>);
	Sun, 31 Aug 2008 21:52:21 -0400
Received: by yx-out-2324.google.com with SMTP id 8so1034475yxm.1
        for <git@vger.kernel.org>; Sun, 31 Aug 2008 18:52:20 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:received:received:message-id:date:from:to
         :subject:cc:in-reply-to:mime-version:content-type
         :content-transfer-encoding:content-disposition:references;
        bh=0F5uw8b2gj8zR/45ESxKHYM9chdchYZHa5MDidyzR7Y=;
        b=kHdVEynalUOK1CYSUn8A/s48w4ozJj7AqCZLzzpM+b7Zw/TncNsL6kVDBzIgkko0xv
         lREey/oYbODpHmm80WQInvQpRsToxUakY2QK/KyvhCLOGYaDFJxQkqzhTun6DI06yMyd
         pP8c0tRFre+qg1NBDVNJ7xchuPZQA88gXFVgg=
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:cc:in-reply-to:mime-version
         :content-type:content-transfer-encoding:content-disposition
         :references;
        b=M26+w+g+PCT866DnegH2qU2yMfB0V+2t+J0LOAAhsrlI5gbm2QuVmkhMCpGVHwiYWk
         kiTPxmqIoNYSdeq3yTuNML8L3FJAHiqhYOOrZfikSCHvbG1F7aV7IMBMN8xniIaqSkqn
         saUII+St12+6ufp1ymUqbh4c9R4C8AYcDdK9U=
Received: by 10.150.124.2 with SMTP id w2mr7801541ybc.170.1220233940315;
        Sun, 31 Aug 2008 18:52:20 -0700 (PDT)
Received: by 10.150.50.2 with HTTP; Sun, 31 Aug 2008 18:52:20 -0700 (PDT)
In-Reply-To: <32541b130808302235g6a23efcfs78efe2ef557cd9c7@mail.gmail.com>
Content-Disposition: inline
Sender: git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/94524>

On Sun, Aug 31, 2008 at 1:35 AM, Avery Pennarun <apenwarr@gmail.com> wrote:
> On Sat, Aug 30, 2008 at 4:37 PM, Jakub Narebski <jnareb@gmail.com> wrote:
>> Or you can use "open $fd, '-|'" to fork, an "manually" exec/system.
>
> Shell quoting is a disaster (including security holes, where relevant)
> waiting to happen.  The above is the only sane way to do it, and it
> isn't very hard to implement.  (Instead of system() in the subprocess,
> you can use exec().)

The perlipc man page has example routines. Search for "safe backtick"
and/or "safe pipe".

j.