From: "Jay Soffian" <jaysoffian@gmail.com>
To: "Jeff King" <peff@peff.net>
Cc: "Jan Engelhardt" <jengelh@medozas.de>, git@vger.kernel.org
Subject: Re: [PATCH 2/3] git-daemon: use getnameinfo to resolve hostname
Date: Wed, 14 Jan 2009 09:22:45 -0500 [thread overview]
Message-ID: <76718490901140622i1c29cd96u1b30042ad9ecb5d9@mail.gmail.com> (raw)
In-Reply-To: <20090114122536.GA5939@coredump.intra.peff.net>
On Wed, Jan 14, 2009 at 7:25 AM, Jeff King <peff@peff.net> wrote:
> So at the very least, you should be adding REMOTE_HOST in _addition_ to
> REMOTE_ADDR, not instead of. But that still leaves one final concern,
> which is that some git-daemon admins might not want to pay the cost for
> a reverse lookup for every request. It's extra network traffic, and adds
> extra latency to the process (but I don't personally run git-daemon, and
> I don't know whether big sites like kernel.org actually care about
> this).
Speaking for large sites everywhere, yes they do care. Enabling DNS
lookups must be configurable.
j.
next prev parent reply other threads:[~2009-01-14 14:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-14 10:48 [PATCH 1/3] git-daemon: single-line logs Jan Engelhardt
2009-01-14 10:48 ` [PATCH 2/3] git-daemon: use getnameinfo to resolve hostname Jan Engelhardt
2009-01-14 10:49 ` [PATCH 3/3] git-daemon: vhost support Jan Engelhardt
2009-01-14 11:33 ` Junio C Hamano
2009-01-14 13:15 ` Jan Engelhardt
2009-01-14 11:33 ` [PATCH 2/3] git-daemon: use getnameinfo to resolve hostname Junio C Hamano
2009-01-14 13:06 ` Jan Engelhardt
2009-01-14 12:25 ` Jeff King
2009-01-14 14:17 ` Adeodato Simó
2009-01-14 14:22 ` Jay Soffian [this message]
2009-01-14 19:25 ` [2/3] " Jan Engelhardt
2009-01-14 11:33 ` [PATCH 1/3] git-daemon: single-line logs Junio C Hamano
2009-01-14 13:03 ` Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76718490901140622i1c29cd96u1b30042ad9ecb5d9@mail.gmail.com \
--to=jaysoffian@gmail.com \
--cc=git@vger.kernel.org \
--cc=jengelh@medozas.de \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).