From: Jay Soffian <jaysoffian@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH] builtin-remote: make rm operation safer in mirrored repository
Date: Tue, 3 Feb 2009 09:38:55 -0500 [thread overview]
Message-ID: <76718490902030638y36299191i1fcc2ab8646b9593@mail.gmail.com> (raw)
In-Reply-To: <7vy6woc5vv.fsf@gitster.siamese.dyndns.org>
On Tue, Feb 3, 2009 at 2:54 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Jeff King <peff@peff.net> writes:
>> However, I have one small nit. The output produces long lines with a lot
>> of repeated text (assuming you have multiple matched branches, which is
>> likely if you have a mirrored setup). So maybe it would be nicer to have
>> something like:
>>
>> warning: non-remote branches were not removed; you can delete them with:
>> git branch -d master
>> git branch -d next
>> git branch -d topic
>>
>> which is a little more obvious (to me, anyway), and allows you to cut
>> and paste if you really did want to delete them.
>
> Thanks for a review, and I actually shared that exact nit when I first
> read the patch. It would be a very good change to collect them in a list
> and show a single warning at the end (I do not have particular preference
> about the cut & paste-ability either way myself).
This is a tough crowd. I'll see what I can do.
j.
next prev parent reply other threads:[~2009-02-03 14:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-01 14:52 git remote rm considered harmful? Jay Soffian
2009-02-01 15:48 ` [PATCH] builtin-remote: make rm operation safer in mirrored repository Jay Soffian
2009-02-02 13:29 ` Jeff King
2009-02-02 13:36 ` Jay Soffian
2009-02-02 18:40 ` Jay Soffian
2009-02-03 7:24 ` Jeff King
2009-02-03 7:54 ` Junio C Hamano
2009-02-03 14:38 ` Jay Soffian [this message]
2009-02-03 14:53 ` Johannes Schindelin
2009-02-03 17:51 ` [PATCH 1/2] builtin-remote: make rm() use properly named variable to hold return value Jay Soffian
2009-02-04 15:34 ` Jeff King
2009-02-03 17:51 ` [PATCH 2/2] builtin-remote: make rm operation safer in mirrored repository Jay Soffian
2009-02-04 15:42 ` Jeff King
2009-02-04 15:56 ` Jay Soffian
2009-02-04 16:06 ` [PATCH] " Jay Soffian
2009-02-04 16:18 ` Jeff King
2009-02-04 16:16 ` [PATCH 2/2] " Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76718490902030638y36299191i1fcc2ab8646b9593@mail.gmail.com \
--to=jaysoffian@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).