git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jay Soffian <jaysoffian@gmail.com>
To: Git Mailing List <git@vger.kernel.org>
Subject: Confused about diff-tree --cc output
Date: Wed, 4 Feb 2009 16:13:39 -0500	[thread overview]
Message-ID: <76718490902041313y44eeb99bya33513bc9818aeb0@mail.gmail.com> (raw)

I'm a bit confused about the output of "git show 8554af" (i.e. git
diff-tree --cc 8554af) on the git tree.

This is a merge of a topic branch of two patches I submitted. If I
understand what Junio did, he branched js/maint-remote-remove-mirror
from maint, applied the two patches I sent via email, then merged that
to next. (Given the topic name he chose, after cooking for a while, I
guess it will eventually merge to maint.)

My understanding of "git show <merge commit>" is that it should only
show changes if the merge resulted in a conflict that needed to be
touched up (ignoring the possibility of an evil merge). Yet git show
on this commit shows this diff:

diff --cc builtin-remote.c
index abc8dd8,07cfdac..db18bcf
--- a/builtin-remote.c
+++ b/builtin-remote.c
@@@ -539,11 -362,14 +549,14 @@@ static int rm(int argc, const char **ar
  		OPT_END()
  	};
  	struct remote *remote;
 -	struct strbuf buf;
 +	struct strbuf buf = STRBUF_INIT;
  	struct known_remotes known_remotes = { NULL, NULL };
  	struct string_list branches = { NULL, 0, 0, 1 };
- 	struct branches_for_remote cb_data = { NULL, &branches, &known_remotes };
- 	int i;
+ 	struct string_list skipped = { NULL, 0, 0, 1 };
+ 	struct branches_for_remote cb_data = {
+ 		NULL, &branches, &skipped, &known_remotes
+ 	};
+ 	int i, result;

  	if (argc != 2)
  		usage_with_options(builtin_remote_usage, options);

This is the same output shown here:

  http://repo.or.cz/w/git.git?a=commitdiff;h=8554af

However, kernel.org's git shows something different (and more what I
would expect, if any output is to be shown):

  http://git.kernel.org/?p=git/git.git;a=commitdiff;h=8554af

(I guess kernel.org is using something like diff-tree -p 3613d1 8554af
--, but I'm not sure why.)

I don't see any other changes to builtin-remote.c that would have
caused a merge conflict, so, color me confused.

j.

             reply	other threads:[~2009-02-04 21:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-04 21:13 Jay Soffian [this message]
2009-02-04 21:56 ` Confused about diff-tree --cc output Junio C Hamano
2009-02-05  3:49   ` Jay Soffian
2009-02-05  8:38     ` Junio C Hamano
2009-02-05  8:57       ` Jay Soffian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=76718490902041313y44eeb99bya33513bc9818aeb0@mail.gmail.com \
    --to=jaysoffian@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).