From: Jay Soffian <jaysoffian@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: "Jakub Narebski" <jnareb@gmail.com>,
"Rafael Garcia-Suarez" <rgarciasuarez@gmail.com>,
git@vger.kernel.org, "Toralf Förster" <toralf.foerster@gmx.de>
Subject: Re: [PATCHv2] gitweb: Better regexp for SHA-1 committag match
Date: Fri, 6 Feb 2009 16:47:57 -0500 [thread overview]
Message-ID: <76718490902061347h5bc35e7et9e1b66bf9dd2c93a@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.1.00.0902061403130.7377@intel-tinevez-2-302>
On Fri, Feb 6, 2009 at 8:03 AM, Johannes Schindelin
<Johannes.Schindelin@gmx.de> wrote:
> Hi,
>
> On Fri, 6 Feb 2009, Jakub Narebski wrote:
>
>> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
>> index f27dbb6..5dcc108 100755
>> --- a/gitweb/gitweb.perl
>> +++ b/gitweb/gitweb.perl
>> @@ -1364,7 +1364,7 @@ sub format_log_line_html {
>> my $line = shift;
>>
>> $line = esc_html($line, -nbsp=>1);
>> - if ($line =~ m/([0-9a-fA-F]{8,40})/) {
>> + if ($line =~ m/\b([0-9a-fA-F]{8,40})\b(!?\@)/) {
>
> Looks good to me!
I wonder if just matching lower-case a-f would be sufficient as well?
j.
next prev parent reply other threads:[~2009-02-06 21:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-02 21:04 webgit highlightes mem adresses as git versions Toralf Förster
2009-02-02 22:54 ` Jakub Narebski
2009-02-03 11:04 ` Toralf Förster
2009-02-03 12:31 ` Johannes Schindelin
2009-02-06 9:12 ` [PATCH] gitweb: Better regexp for SHA-1 committag match Jakub Narebski
2009-02-06 9:49 ` Rafael Garcia-Suarez
2009-02-06 10:26 ` Jakub Narebski
2009-02-06 10:31 ` Rafael Garcia-Suarez
2009-02-06 10:49 ` [PATCHv2] " Jakub Narebski
2009-02-06 13:03 ` Johannes Schindelin
2009-02-06 21:47 ` Jay Soffian [this message]
2009-02-06 22:00 ` Jakub Narebski
2009-02-07 7:48 ` Junio C Hamano
2009-02-07 8:34 ` Jakub Narebski
2009-02-07 8:48 ` Junio C Hamano
2009-02-07 9:25 ` Jakub Narebski
2009-02-07 9:32 ` demerphq
2009-02-07 10:09 ` Jakub Narebski
2009-02-07 14:01 ` Jakub Narebski
2009-02-07 9:22 ` [PATCH] " demerphq
2009-02-07 10:07 ` Jakub Narebski
2009-02-07 13:30 ` demerphq
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76718490902061347h5bc35e7et9e1b66bf9dd2c93a@mail.gmail.com \
--to=jaysoffian@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=rgarciasuarez@gmail.com \
--cc=toralf.foerster@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).