From: Jay Soffian <jaysoffian@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] builtin-branch: improve output when displaying remote branches
Date: Fri, 13 Feb 2009 03:06:25 -0500 [thread overview]
Message-ID: <76718490902130006r4f125752wa207056d72630e84@mail.gmail.com> (raw)
In-Reply-To: <7veiy2eptb.fsf@gitster.siamese.dyndns.org>
On Fri, Feb 13, 2009 at 2:52 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Jay Soffian <jaysoffian@gmail.com> writes:
>
>> This strikes me as premature optimization.
>
> It is *not* an optimization. It is reduction of code duplication to
> improve maintainability before copy-and-paste gets out of hand.
>
> The proper adjective for it is not "premature" but "preemptive".
I'll re-roll the patch again. However, if you look at the rest of
builtin-branch.c, you'll see there are more places than that which are
structured similarly (e.g. delete_branches). So if someone wanted to
add another branch type, that would be the time (IMO), to refactor the
statement at the top of append_ref().
j.
next prev parent reply other threads:[~2009-02-13 8:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-10 11:01 [PATCH] builtin-branch: improve output when displaying remote branches Jay Soffian
2009-02-11 6:47 ` Jay Soffian
2009-02-12 3:49 ` Junio C Hamano
2009-02-12 4:30 ` Jay Soffian
2009-02-12 5:42 ` Junio C Hamano
2009-02-13 5:34 ` [PATCH v2] " Jay Soffian
2009-02-13 6:35 ` Junio C Hamano
2009-02-13 6:45 ` Jay Soffian
2009-02-13 7:52 ` Junio C Hamano
2009-02-13 8:06 ` Jay Soffian [this message]
2009-02-13 9:40 ` [PATCH v3] " Jay Soffian
2009-02-13 6:47 ` [PATCH v2] " martin f krafft
2009-02-13 7:36 ` Junio C Hamano
2009-02-13 7:37 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76718490902130006r4f125752wa207056d72630e84@mail.gmail.com \
--to=jaysoffian@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).