git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jay Soffian <jaysoffian@gmail.com>
To: Thomas Rast <trast@student.ethz.ch>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
	Daniel Barkalow <barkalow@iabervon.org>
Subject: Re: [RFC PATCH] format-patch: thread as reply to cover letter even  with in-reply-to
Date: Mon, 16 Feb 2009 15:22:14 -0500	[thread overview]
Message-ID: <76718490902161222p7f1ecbf9x6f965ff94b3cfae7@mail.gmail.com> (raw)
In-Reply-To: <1234810812-30499-1-git-send-email-trast@student.ethz.ch>

On Mon, Feb 16, 2009 at 2:00 PM, Thomas Rast <trast@student.ethz.ch> wrote:
> Currently, format-patch --thread --cover-letter --in-reply-to $parent
> makes all mails, including the cover letter, a reply to $parent.
> However, we would want the reader to consider the cover letter above
> all the patches.
>
> This changes the semantics so that only the cover letter is a reply to
> $parent, while all the patches are formatted as replies to the cover
> letter.

I think this change may be okay, but I think to go with it the
cover-letter and all the patches should have a "References:" header
with the message-id given by --in-reply-to.

RFC 2822 says:

   The "In-Reply-To:" and "References:" fields are used when creating a
   reply to a message.  They hold the message identifier of the original
   message and the message identifiers of other messages (for example,
   in the case of a reply to a message which was itself a reply).  The
   "In-Reply-To:" field may be used to identify the message (or
   messages) to which the new message is a reply, while the
   "References:" field may be used to identify a "thread" of
   conversation.

j.

  reply	other threads:[~2009-02-16 20:23 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-14 19:54 [PATCH] bash completion: offer more options for gitk Thomas Rast
2009-02-15  9:33 ` Junio C Hamano
2009-02-15  9:56   ` Santi Béjar
2009-02-16 16:34     ` [PATCH v2 0/2] bash completion: more options for gitk/log/shortlog Thomas Rast
2009-02-16 16:38       ` Thomas Rast
2009-02-16 19:00       ` [RFC PATCH] format-patch: thread as reply to cover letter even with in-reply-to Thomas Rast
2009-02-16 20:22         ` Jay Soffian [this message]
2009-02-16 20:34           ` Thomas Rast
2009-02-16 20:52             ` Jakub Narebski
2009-02-16 23:27               ` Thomas Rast
2009-02-19 21:26                 ` [PATCH 0/4] format-patch --cover-letter --in-reply-to Thomas Rast
2009-02-19 21:26                   ` [PATCH 1/4] format-patch: threading test reactivation Thomas Rast
2009-02-19 21:26                   ` [PATCH 2/4] format-patch: track several references Thomas Rast
2009-02-19 22:41                     ` Daniel Barkalow
2009-02-20 19:55                       ` [PATCH v2 next 0/4] format-patch --cover-letter --in-reply-to Thomas Rast
2009-02-20 19:55                         ` [PATCH v2 next 1/4] format-patch: threading test reactivation Thomas Rast
2009-02-20 19:55                         ` [PATCH v2 next 2/4] format-patch: track several references Thomas Rast
2009-02-20 19:55                         ` [PATCH v2 next 3/4] format-patch: thread as reply to cover letter even with in-reply-to Thomas Rast
2009-02-20 19:55                         ` [PATCH v2 next 4/4] format-patch: support deep threading Thomas Rast
2009-02-22 16:49                         ` [PATCH v2 next 0/4] format-patch --cover-letter --in-reply-to Junio C Hamano
2009-02-19 21:26                   ` [PATCH 3/4] format-patch: thread as reply to cover letter even with in-reply-to Thomas Rast
2009-02-19 21:26                   ` [PATCH 4/4] format-patch: support deep threading Thomas Rast
2009-02-16 16:34     ` [PATCH v2 1/2] bash completion: refactor common log, shortlog and gitk options Thomas Rast
2009-02-16 16:34     ` [PATCH v2 2/2] bash completion: only show 'log --merge' if merging Thomas Rast
2009-02-18 17:05       ` Shawn O. Pearce
2009-02-18 19:02         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=76718490902161222p7f1ecbf9x6f965ff94b3cfae7@mail.gmail.com \
    --to=jaysoffian@gmail.com \
    --cc=barkalow@iabervon.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=trast@student.ethz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).