git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jay Soffian <jaysoffian@gmail.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH 1/2] add basic branch display tests
Date: Wed, 18 Feb 2009 22:51:27 -0500	[thread overview]
Message-ID: <76718490902181951p54dc222ai5ac6397f3471fc44@mail.gmail.com> (raw)
In-Reply-To: <20090219034504.GA19862@coredump.intra.peff.net>

On Wed, Feb 18, 2009 at 10:45 PM, Jeff King <peff@peff.net> wrote:
> But here we stick the "remotes/" head on, since we are showing both
> types. But the right hand side of the symref doesn't get the same
> treatment.
>
> I don't think it's a big deal, but I wasn't sure if it was intentional,

It was intentional on my part. I thought appending it a second time
was redundant, and the remotes/ prefix on the LHS is just their to
distinguish remote branches from local.

> I also had a brief thought that reprinting the <remote> is pointless.
> That is, printing
>
>  origin/HEAD -> master
>
> shows what is happening with less text due to the context (i.e., we
> already know we are talking about remote "origin" -- and if it isn't in
> origin, we already show more). But that is probably a bad idea; that
> context is missing if you were to try to do something like "git show";
> <remote>/<branch> would work, but <branch> wouldn't.

Exactly. :-)

Thanks for the tests. If I had added them myself I wouldn't have you
publicly questioning my intent. ;-)

j.

  reply	other threads:[~2009-02-19  3:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1234980819u.git.johannes.schindelin@gmx.de>
2009-02-18 18:14 ` [PATCH] Avoid segfault with 'git branch' when the HEAD is detached Johannes Schindelin
2009-02-18 20:36   ` Jay Soffian
2009-02-19  0:45   ` Jeff King
2009-02-19  1:15     ` Johannes Schindelin
2009-02-19  3:24       ` Jeff King
2009-02-19  3:33         ` Jeff King
2009-02-19  3:34           ` [PATCH 1/2] add basic branch display tests Jeff King
2009-02-19  3:45             ` Jeff King
2009-02-19  3:51               ` Jay Soffian [this message]
2009-02-19  3:53                 ` Jeff King
2009-02-19  3:35           ` [PATCH 2/2] branch: clean up repeated strlen Jeff King
2009-02-19 11:31             ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=76718490902181951p54dc222ai5ac6397f3471fc44@mail.gmail.com \
    --to=jaysoffian@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).