git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jay Soffian <jaysoffian@gmail.com>
To: Marc Branchaud <marcnarc@xiplink.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Johannes Sixt <j.sixt@viscovery.net>
Subject: Re: [PATCH 4/4] remote: new show output style
Date: Fri, 20 Feb 2009 17:55:15 -0500	[thread overview]
Message-ID: <76718490902201455y22b8a861x246fd22845ae282c@mail.gmail.com> (raw)
In-Reply-To: <499F2FF6.10601@xiplink.com>

On Fri, Feb 20, 2009 at 5:34 PM, Marc Branchaud <marcnarc@xiplink.com> wrote:
> All valid points.  But, dang it, I really think intelligently adding that
> extra space the right thing to do.

Already coded. :-)

> It wouldn't be all that tedious -- you could detect the need for the extra
> space in config_read_branches() the first time type is set to REBASE, no?

What is that about everything being easy for the man who doesn't have
to do it? :-)

(It was no big deal, I just needed to rework a few things cause I'd
painted myself into a corner.)

>> I left that out on purpose. The only folks with push refspecs put them
>> their manually, and the raw refspec is clearer and more concise than
>> any English words can convey. That was my reasoning anyway.
>
> Fair enough.

Yeah, I'm fixing this too by properly expanded out the refspecs the
same way that it's done by {builtin-send-pack, http-push}.c.

Hopefully I can have a patch out later today.

j.

  reply	other threads:[~2009-02-20 22:56 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-19  5:14 [PATCH 0/4] Improve "remote show" output Jay Soffian
2009-02-19  5:14 ` [PATCH 1/4] remote: minor code cleanups in preparation for changing "show" output Jay Soffian
2009-02-19  5:14   ` [PATCH 2/4] remote: move append_ref_to_tracked_list to get rid of prototype Jay Soffian
2009-02-19  5:14     ` [PATCH 3/4] string-list: add for_each_string_list() Jay Soffian
2009-02-19  5:14       ` [PATCH 4/4] remote: new show output style Jay Soffian
2009-02-19 16:03         ` Marc Branchaud
2009-02-19 16:16           ` Sverre Rabbelier
2009-02-19 16:31             ` Marc Branchaud
2009-02-19 16:33               ` Sverre Rabbelier
2009-02-19 16:17           ` Rostislav Svoboda
2009-02-19 17:57           ` Jay Soffian
2009-02-19 17:59             ` Jay Soffian
2009-02-19 18:58             ` Julian Phillips
2009-02-20 22:34             ` Marc Branchaud
2009-02-20 22:55               ` Jay Soffian [this message]
2009-02-19 19:29         ` Johannes Sixt
2009-02-19 19:51           ` Jay Soffian
2009-02-20  7:19   ` [PATCH 1/4] remote: minor code cleanups in preparation for changing "show" output Junio C Hamano
2009-02-20 10:50     ` Jay Soffian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=76718490902201455y22b8a861x246fd22845ae282c@mail.gmail.com \
    --to=jaysoffian@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=j.sixt@viscovery.net \
    --cc=marcnarc@xiplink.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).