git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jay Soffian <jaysoffian@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>
Subject: Re: [PATCH 00/23] builtin-remote improvments
Date: Tue, 24 Feb 2009 12:49:47 -0500	[thread overview]
Message-ID: <76718490902240949i6ef70fc9i88b7a30a069ef374@mail.gmail.com> (raw)
In-Reply-To: <7v7i3fhgye.fsf@gitster.siamese.dyndns.org>

On Tue, Feb 24, 2009 at 12:39 PM, Junio C Hamano <gitster@pobox.com> wrote:
> I don't mind pulling, as it is less work for me, but it would make
> harder for others to see the changes in flight and discuss, so...
>
> Even though I'd need to re-read them before merging them to 'next', I also
> think the earlier remote-set-head series and Jeff's changes on top of it
> looked more or less reasonable.  Perhaps I should rebase them on top of
> 'master' before moving them to 'next' and then you can build on top, which
> would reduce your new series by about 10 commits.

Putting Jeff's changes first reduces churn a small amount, as we don't
introduce new code just to change it a few commits later in the same
topic. So it keeps the history marginally cleaner. That was my
thinking anyway. Otherwise you may as well just use what I sent last
night and let me add one more patch on-top to clean-up that unused
variable that gets passed to get_head_names().

Your call. :-)

j.

      reply	other threads:[~2009-02-24 17:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-24  9:50 [PATCH 00/23] builtin-remote improvments Jay Soffian
2009-02-24 10:53 ` Jay Soffian
2009-02-24 11:01   ` Marius Storm-Olsen
2009-02-24 17:36     ` Jay Soffian
2009-02-24 17:39   ` Junio C Hamano
2009-02-24 17:49     ` Jay Soffian [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=76718490902240949i6ef70fc9i88b7a30a069ef374@mail.gmail.com \
    --to=jaysoffian@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).