git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jay Soffian <jaysoffian@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, jean-luc malet <jeanluc.malet@gmail.com>
Subject: Re: [PATCH 3/3] builtin-merge: add support for default merge options
Date: Fri, 6 Mar 2009 18:16:08 -0500	[thread overview]
Message-ID: <76718490903061516l62869424q4bd4cfa64fe2195e@mail.gmail.com> (raw)
In-Reply-To: <7vr61aqngu.fsf@gitster.siamese.dyndns.org>

On Fri, Mar 6, 2009 at 5:46 PM, Junio C Hamano <gitster@pobox.com> wrote:

> When you are on branch "frotz", your config have both merge.options and
> branch.frotz.mergeoptions, and you give some other options from the
> command line, how should they interact?  I'd expect the branch.*.options
> to take effect, ignoring merge.options entirely.

Really? I didn't think that would be consistent with the fact that the
the command line options override branch.*.options, but don't replace
them. So I specifically coded it such that there are three separate
layers all merged together. (Which is also how I documented it in the
man page.)

> If for some reason you would want to have cumulative options across

Which I do, or I wouldn't have coded it that way. :-)

> branch.*.merge, merge.options and the command line, then you would instead
> keep two separate strings, and call git_config_option_string() for both of
> them, before processing the real command line options.

Ah, right that would be better.

j.

  reply	other threads:[~2009-03-06 23:17 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-06 22:15 [PATCH 0/3] Re: how to have --no-ff be the default for all branch Jay Soffian
2009-03-06 22:15 ` [PATCH 1/3] config: add git_config_option_string() Jay Soffian
2009-03-06 22:15   ` [PATCH 2/3] builtin-merge: refactor to use git_config_option_string Jay Soffian
2009-03-06 22:15     ` [PATCH 3/3] builtin-merge: add support for default merge options Jay Soffian
2009-03-06 22:46       ` Junio C Hamano
2009-03-06 23:16         ` Jay Soffian [this message]
2009-03-07  0:44           ` [PATCH v2 " Jay Soffian
2009-03-07  0:58           ` [PATCH " Junio C Hamano
2009-03-07  1:56             ` Jay Soffian
2009-03-07  7:18               ` Junio C Hamano
2009-03-07 13:48                 ` Jay Soffian
2009-03-07 19:31                 ` jean-luc malet
2010-03-19 14:19                   ` jean-luc malet
2010-03-19 14:54                     ` Jay Soffian
2010-04-02 17:19                       ` jean-luc malet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=76718490903061516l62869424q4bd4cfa64fe2195e@mail.gmail.com \
    --to=jaysoffian@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jeanluc.malet@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).