From: Jay Soffian <jaysoffian@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Johannes Sixt <j.sixt@viscovery.net>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: t5505-remote fails on Windows
Date: Thu, 19 Mar 2009 00:56:37 -0400 [thread overview]
Message-ID: <76718490903182156y3b2b9d8aw708829a6ed151aa@mail.gmail.com> (raw)
In-Reply-To: <20090319044313.GA341@coredump.intra.peff.net>
On Thu, Mar 19, 2009 at 12:43 AM, Jeff King <peff@peff.net> wrote:
> The patch below probably fixes it, but as I can't actually reproduce
> here, it is largely untested.
Thanks.
> As a side note, I find this solution a little bit ugly. String lists
> should sort on their strings, not on some other random magic in the util
> field. This usage really abuses string_list a bit as a data type because
> we have no generic "list" type.
I really don't think so. The string_list API accommodates this case
quite nicely. So why not?
(And anyway, what sane configuration pushes a single local branch to
multiple remote branches? But the refspecs allow it, so I accommodated
it in builtin-remote and tested for it. I never actually tested
whether git push works with it tho.) :-)
j.
next prev parent reply other threads:[~2009-03-19 4:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-18 11:42 t5505-remote fails on Windows Johannes Sixt
2009-03-19 4:18 ` Jeff King
2009-03-19 4:43 ` Jeff King
2009-03-19 4:56 ` Jay Soffian [this message]
2009-03-19 5:03 ` Jeff King
2009-03-19 7:20 ` Johannes Sixt
2009-03-19 20:04 ` Jeff King
2009-03-19 10:36 ` Johannes Schindelin
2009-03-19 11:02 ` Junio C Hamano
2009-03-19 15:00 ` Jay Soffian
2009-03-19 20:03 ` Jeff King
2009-03-19 23:15 ` Johannes Schindelin
2009-03-22 8:59 ` [PATCH] remote: improve sorting of "configure for git push" list Jeff King
2009-03-22 14:47 ` Jay Soffian
2009-03-22 21:58 ` Junio C Hamano
2009-03-23 7:56 ` Johannes Sixt
2009-03-23 8:09 ` Junio C Hamano
2009-03-19 19:52 ` t5505-remote fails on Windows Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76718490903182156y3b2b9d8aw708829a6ed151aa@mail.gmail.com \
--to=jaysoffian@gmail.com \
--cc=git@vger.kernel.org \
--cc=j.sixt@viscovery.net \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).