From: Jay Soffian <jaysoffian@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Jeff King <peff@peff.net>, Johannes Sixt <j.sixt@viscovery.net>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: t5505-remote fails on Windows
Date: Thu, 19 Mar 2009 11:00:50 -0400 [thread overview]
Message-ID: <76718490903190800o4d82a037mb6fc5bf901c418d8@mail.gmail.com> (raw)
In-Reply-To: <7vhc1pai84.fsf@gitster.siamese.dyndns.org>
On Thu, Mar 19, 2009 at 7:02 AM, Junio C Hamano <gitster@pobox.com> wrote:
>> Do we really want an API for that? Calling qsort() directly should be
>> obvious enough, no?
>
> I think so. If it were done like this (notice the lack of double
> indirection in the cmp_fn signature):
>
> typedef int string_list_item_cmp_fn(const struct string_list_item *, const struct string_list_item *);
>
> void sort_string_list_with_fn(struct string_list *list, string_list_item_cmp_fn *);
>
> it would have made more sense, though.
Oh, wow, sorry, I didn't even realize Jeff had just added that
function. Somehow I missed that part of his patch.
j.
next prev parent reply other threads:[~2009-03-19 15:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-18 11:42 t5505-remote fails on Windows Johannes Sixt
2009-03-19 4:18 ` Jeff King
2009-03-19 4:43 ` Jeff King
2009-03-19 4:56 ` Jay Soffian
2009-03-19 5:03 ` Jeff King
2009-03-19 7:20 ` Johannes Sixt
2009-03-19 20:04 ` Jeff King
2009-03-19 10:36 ` Johannes Schindelin
2009-03-19 11:02 ` Junio C Hamano
2009-03-19 15:00 ` Jay Soffian [this message]
2009-03-19 20:03 ` Jeff King
2009-03-19 23:15 ` Johannes Schindelin
2009-03-22 8:59 ` [PATCH] remote: improve sorting of "configure for git push" list Jeff King
2009-03-22 14:47 ` Jay Soffian
2009-03-22 21:58 ` Junio C Hamano
2009-03-23 7:56 ` Johannes Sixt
2009-03-23 8:09 ` Junio C Hamano
2009-03-19 19:52 ` t5505-remote fails on Windows Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76718490903190800o4d82a037mb6fc5bf901c418d8@mail.gmail.com \
--to=jaysoffian@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).