From: Jay Soffian <jaysoffian@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: Broken t9001 tests
Date: Thu, 2 Apr 2009 10:14:43 -0400 [thread overview]
Message-ID: <76718490904020714x3f00d5fu6f13587be383be1b@mail.gmail.com> (raw)
In-Reply-To: <20090402134019.GA26699@coredump.intra.peff.net>
On Thu, Apr 2, 2009 at 9:40 AM, Jeff King <peff@peff.net> wrote:
> On Thu, Apr 02, 2009 at 03:22:33PM +0200, Johannes Schindelin wrote:
>
>> only when I revert both dc1460a(send-email: ask_default should apply to
>> all emails, not just the first) and c18f75a(send-email: add tests for
>> refactored prompting) does my test suite pass without asking me
>> _interactively_ (twice, even) if I want to
>>
>> Send this email? ([y]es|[n]o|[q]uit|[a]ll):
>>
>> Please fix.
Sorry, as Jeff mentions:
> Try
>
> http://article.gmane.org/gmane.comp.version-control.git/115280
And BTW, it's not as if I didn't test. The "going interactive" issue
is hidden by bash. But don't worry, I've since downloaded and
installed dash just for running git tests, so it won't happen again.
> Junio seems to have picked up the first part of the series, but not this
> fix. I'm not sure why.
Junio, may I please draw you attention to 3/4 and 4/4 at the link
above. Please amend the commit message for 3/4 though. It says it
corrects commit 67f1fe5 which is wrong. Please sed
's/67f1fe5/c18f75a/' in that message.
Thanks,
j.
next prev parent reply other threads:[~2009-04-02 14:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-02 13:22 Broken t9001 tests Johannes Schindelin
2009-04-02 13:40 ` Jeff King
2009-04-02 14:14 ` Jay Soffian [this message]
2009-04-02 18:07 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76718490904020714x3f00d5fu6f13587be383be1b@mail.gmail.com \
--to=jaysoffian@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).