From: Jay Soffian <jaysoffian@gmail.com>
To: Bruce Stephens <bruce.stephens@isode.com>
Cc: Dan McGee <dpmcgee@gmail.com>, git@vger.kernel.org
Subject: Re: git send-email prompting too much
Date: Sat, 4 Apr 2009 22:49:14 -0400 [thread overview]
Message-ID: <76718490904041949w4b66d9ffkbf06299fbff22db9@mail.gmail.com> (raw)
In-Reply-To: <76718490904041913s2c769022t92ca194263e29eb0@mail.gmail.com>
On Sat, Apr 4, 2009 at 10:13 PM, Jay Soffian <jaysoffian@gmail.com> wrote:
> Wait. Did hitting just enter work in the past? Because I tested this
> before I made this commit and at least on my machine, hitting enter
> just presented the prompt again. So I retained that behavior.
Argh. I should read my own commit message. I claim:
2) "Who should the emails be sent to?". Previously this prompt passed a
second argument ("") to $term->readline() which was ignored. I believe
the intent was to allow the user to just hit return. Now the user
can do so, or type ctrl-d.
3) "Message-ID to be used as In-Reply-To for the first email?".
Previously this prompt passed a second argument (effectively undef) to
$term->readline() which was ignored. I believe the intent was the same
as for (2), to allow the user to just hit return. Now the user can do
so, or type ctrl-d.
Clearly I broke something. Will send a patch shortly. :-(
j.
next prev parent reply other threads:[~2009-04-05 2:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-04 17:02 git send-email prompting too much Dan McGee
2009-04-04 17:12 ` Bruce Stephens
2009-04-05 2:13 ` Jay Soffian
2009-04-05 2:49 ` Jay Soffian [this message]
2009-04-05 9:45 ` Junio C Hamano
2009-04-05 3:23 ` [PATCH] send-email: fix nasty bug in ask() function Jay Soffian
2009-04-05 3:31 ` Jay Soffian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76718490904041949w4b66d9ffkbf06299fbff22db9@mail.gmail.com \
--to=jaysoffian@gmail.com \
--cc=bruce.stephens@isode.com \
--cc=dpmcgee@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).