From: Jay Soffian <jaysoffian@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Matthieu Moy <Matthieu.Moy@imag.fr>,
gitster@pobox.com, git@vger.kernel.org
Subject: Re: [PATCH] Fix uninitialized memory in get_local_heads()
Date: Mon, 20 Apr 2009 09:51:18 -0400 [thread overview]
Message-ID: <76718490904200651t6cee0d73n8cbdea8099487654@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.1.00.0904201219240.6955@intel-tinevez-2-302>
On Mon, Apr 20, 2009 at 6:20 AM, Johannes Schindelin
<Johannes.Schindelin@gmx.de> wrote:
>
> In 454e202(move duplicated get_local_heads() to remote.c), a static
> local variable was moved into a function, but not initialized.
>
> This resulted in a crash when trying to push from an empty repository.
>
> Noticed by Matthieu Moy.
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Doh. Thank you for the fix.
j.
next prev parent reply other threads:[~2009-04-20 13:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-20 9:48 [PATCH] BUG: git push on an empty clone segfaults Matthieu Moy
2009-04-20 10:20 ` [PATCH] Fix uninitialized memory in get_local_heads() Johannes Schindelin
2009-04-20 13:51 ` Jay Soffian [this message]
2009-04-20 10:33 ` [PATCH] BUG: git push on an empty clone segfaults Junio C Hamano
2009-04-20 10:55 ` Johannes Schindelin
2009-04-20 11:13 ` Junio C Hamano
2009-04-20 13:55 ` Petr Baudis
2009-04-20 14:30 ` Johannes Schindelin
2009-04-20 20:46 ` Petr Baudis
2009-04-20 11:07 ` Matthieu Moy
2009-04-20 11:09 ` [PATCH] clone: add test for push on an empty clone Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76718490904200651t6cee0d73n8cbdea8099487654@mail.gmail.com \
--to=jaysoffian@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=Matthieu.Moy@imag.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).