git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jay Soffian <jaysoffian@gmail.com>
To: Vitaly Mayatskikh <v.mayatskih@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-send-email: parse all messages in mbox
Date: Thu, 14 May 2009 10:48:33 -0400	[thread overview]
Message-ID: <76718490905140748n390d0e85t8349b69fc6debc2a@mail.gmail.com> (raw)
In-Reply-To: <873abbeoqc.wl%vmayatsk@redhat.com>

On Mon, May 11, 2009 at 9:46 AM, Vitaly Mayatskikh
<v.mayatskih@gmail.com> wrote:
> Currently git-send-email sends all mbox in one email. This seems to be wrong,
> because mbox can contain several messages. For example,
> `git format-patch --stdout' forms mbox file with all patches in it.

Just out of curiosity, what is the motivation for this patch?

By default, format-patch generates a file per commit, which is what
send-email currently expects. You can also specify one or more commits
to send-email directly, in which case it runs format-patch on your
behalf. And, send-email cannot handle messages on stdin, so "git
format-patch | git send-email" is not a valid workflow, even after
this patch.

So the only way I can see this being useful is if you're doing something like:

$ git format-patch --stdout > mbox
$ git send-email mbox

Or you can combine those in bash with:

$ git send-email <(git format-patch --stdout)

But, why? The only way this patch would make any sense to me is if it
_also_ extended send-email to read its messages from stdin.

j.

  parent reply	other threads:[~2009-05-14 14:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-11 13:46 [PATCH] git-send-email: parse all messages in mbox Vitaly Mayatskikh
2009-05-12 23:27 ` Junio C Hamano
2009-05-14  9:47   ` Vitaly Mayatskikh
2009-05-14 14:48 ` Jay Soffian [this message]
2009-05-14 18:41   ` Vitaly Mayatskikh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=76718490905140748n390d0e85t8349b69fc6debc2a@mail.gmail.com \
    --to=jaysoffian@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=v.mayatskih@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).