From: Jay Soffian <jaysoffian@gmail.com>
To: markus.heidelberg@web.de, Paolo Bonzini <bonzini@gnu.org>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH resend] Test cccmd in t9001-send-email.sh and fix two bugs
Date: Thu, 18 Jun 2009 08:49:50 -0400 [thread overview]
Message-ID: <76718490906180549mb65dc17va513c294038470d2@mail.gmail.com> (raw)
In-Reply-To: <200906181211.39440.markus.heidelberg@web.de>
On Thu, Jun 18, 2009 at 6:11 AM, Markus
Heidelberg<markus.heidelberg@web.de> wrote:
> Paolo Bonzini, 17.06.2009:
>> The first bug is that the --suppress-cc option for `cccmd' was
>> misspelled as `ccmd' in the code.
Good catch. That error has actually existed since --suppress-cc was
introduced in 65648283. But nor did I (sheesh, aren't many eyes
supposed to make all bugs shallow?) catch it in 3531e2703d.
> Then I noticed that the documentation mentions ccbody, but the code uses
> bodycc.
> The author seemed to intend using bodycc, since it is also used in the
> tests and the commit message (3531e2703d, send-email: --suppress-cc
> improvements, 2009-02-15), but besides the documentation, ccbody is used
> in the bash completion.
Wow, I'm pretty sure I intended bodycc. And I'm not even dyslexic.
Thanks,
j.
prev parent reply other threads:[~2009-06-18 12:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-17 7:17 [PATCH resend] Test cccmd in t9001-send-email.sh and fix two bugs Paolo Bonzini
2009-06-18 10:11 ` Markus Heidelberg
2009-06-18 12:31 ` [PATCH v2] Test cccmd in t9001-send-email.sh and fix some bugs Paolo Bonzini
2009-06-19 10:06 ` Markus Heidelberg
2009-06-18 12:49 ` Jay Soffian [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76718490906180549mb65dc17va513c294038470d2@mail.gmail.com \
--to=jaysoffian@gmail.com \
--cc=bonzini@gnu.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=markus.heidelberg@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).