From: Jay Soffian <jaysoffian@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, David Aguilar <davvid@gmail.com>
Subject: Re: [PATCH] mergetool--lib: add diffmerge as a pre-configured mergetool option
Date: Wed, 9 Dec 2009 16:16:39 -0800 [thread overview]
Message-ID: <76718490912091616n250a4b93h941c91b572c5be1c@mail.gmail.com> (raw)
In-Reply-To: <7vaaxrn10o.fsf@alter.siamese.dyndns.org>
On Wed, Dec 9, 2009 at 4:08 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Perhaps it is a better approach to first eject bulk of code for the
> backends we currently support under these case statements into separate
> files, one per backend, move them to mergetool/ subdirectory in the source
> tree, install them as "$(share)/git-core/mergetool/$toolname", and at
> runtime source them? That way, a patch to add a new backend can be as
> simple as adding a new file in mergetool/ and doing nothing else. Also an
> end user can privately add support to a new backend much more easily.
>
> Anybody want to try that approach?
Sure. There may also be value in emulating the mercurial approach:
http://mercurial.selenic.com/wiki/MergeToolConfiguration
I'll give both a shot.
j.
next prev parent reply other threads:[~2009-12-10 0:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-08 20:01 [PATCH] mergetool--lib: add diffmerge as a pre-configured mergetool option Jay Soffian
2009-12-09 22:34 ` Charles Bailey
2009-12-09 23:14 ` Jay Soffian
2009-12-10 0:08 ` Junio C Hamano
2009-12-10 0:16 ` Jay Soffian [this message]
2011-08-16 10:09 ` David Aguilar
2011-08-16 17:43 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76718490912091616n250a4b93h941c91b572c5be1c@mail.gmail.com \
--to=jaysoffian@gmail.com \
--cc=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).