git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eugene Sajine <euguess@gmail.com>
To: kusmabite@gmail.com
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Wincent Colaiuta <win@wincent.com>,
	Avery Pennarun <apenwarr@gmail.com>,
	Jacob Helwig <jacob.helwig@gmail.com>,
	git@vger.kernel.org
Subject: Re: [BUG] - "git commit --amend" commits, when exiting the editor  with no changes written
Date: Tue, 2 Feb 2010 18:48:13 -0500	[thread overview]
Message-ID: <76c5b8581002021548n129b3997r48ee6f6df5a1a4eb@mail.gmail.com> (raw)
In-Reply-To: <40aa078e1002021540i13e35776xd733a4e40f34b477@mail.gmail.com>

>
> This is where you're wrong. The reason why commit (without --amend) is
> aborting when you don't save is that the default commit message is
> empty, not that it wasn't saved. In fact, just saving still makes in
> abort. You need to add something to the commit message and then save
> to get it to perform the commit.
>
>> Same should be applied to rebase -i and of course to commit --amend as
>> it is still commit operation.
>>
>
> "rebase -i" and "commit --amend" already has the exact same logic as
> commit without ammend in this regard - they abort if the buffer is
> empty.
>
> --
> Erik "kusma" Faye-Lund
>

Thank you, but I'm not wrong, as i described the exact same thing
somewhere in my second or third message, without even knowing the
implementation details. I understand the reason WHY it is like it is,
i just don't like it as it is inconsistent and IMHO incorrect.

Thanks,
Eugene

  reply	other threads:[~2010-02-02 23:48 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-02 20:07 [BUG] - "git commit --amend" commits, when exiting the editor with no changes written Eugene Sajine
2010-02-02 20:14 ` Jacob Helwig
2010-02-02 20:27   ` Avery Pennarun
2010-02-02 20:47     ` Eugene Sajine
2010-02-02 20:58       ` Wincent Colaiuta
2010-02-02 21:56         ` Eugene Sajine
2010-02-02 22:03           ` Erik Faye-Lund
2010-02-02 22:06           ` Wincent Colaiuta
2010-02-02 22:31             ` Eugene Sajine
2010-02-02 22:35               ` Avery Pennarun
2010-02-02 23:02                 ` Eugene Sajine
2010-02-02 23:15                   ` Johannes Schindelin
2010-02-02 23:27                     ` Eugene Sajine
2010-02-02 23:40                   ` Avery Pennarun
2010-02-03  6:15                     ` Larry D'Anna
2010-02-03  9:31                       ` Jeff King
2010-02-03 10:15                         ` Jeff King
2010-02-03 18:19                         ` Avery Pennarun
2010-02-02 23:00               ` Johannes Schindelin
2010-02-02 23:34                 ` Eugene Sajine
2010-02-02 23:40                   ` Erik Faye-Lund
2010-02-02 23:48                     ` Eugene Sajine [this message]
2010-02-03  0:16                       ` Erik Faye-Lund
2010-02-03  0:55                         ` Eugene Sajine
2010-02-03  1:59                           ` SZEDER Gábor
2010-02-03  7:34                             ` Matthieu Moy
2010-02-03  9:08                               ` aborting rebase -i right at the start, was " Johannes Schindelin
2010-02-03  9:41                                 ` SZEDER Gábor
2010-02-03 16:02                                   ` Eugene Sajine
2010-02-03  7:31                       ` Matthieu Moy
2010-02-03 15:45                         ` Eugene Sajine
2010-02-03 17:51                           ` Jonathan Nieder
2010-02-03 17:53                             ` Jonathan Nieder
2010-02-03 18:21                           ` Wincent Colaiuta
2010-02-03 18:49                             ` Eugene Sajine
2010-02-03 18:57                               ` Avery Pennarun
2010-02-03 19:27                                 ` Eugene Sajine
2010-02-03 19:54                                   ` Avery Pennarun
2010-02-03 18:47                           ` Matthieu Moy
2010-02-02 23:58                   ` Johannes Schindelin
2010-02-03  0:09                     ` Eugene Sajine
2010-02-03  9:04                       ` Johannes Schindelin
2010-02-03  9:46                       ` Paolo Bonzini
2010-02-02 23:44                 ` Junio C Hamano
2010-02-02 21:18       ` Avery Pennarun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=76c5b8581002021548n129b3997r48ee6f6df5a1a4eb@mail.gmail.com \
    --to=euguess@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=apenwarr@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jacob.helwig@gmail.com \
    --cc=kusmabite@gmail.com \
    --cc=win@wincent.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).