git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eugene Sajine <euguess@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Wincent Colaiuta <win@wincent.com>,
	Avery Pennarun <apenwarr@gmail.com>,
	Jacob Helwig <jacob.helwig@gmail.com>,
	git@vger.kernel.org
Subject: Re: [BUG] - "git commit --amend" commits, when exiting the editor  with no changes written
Date: Tue, 2 Feb 2010 19:09:10 -0500	[thread overview]
Message-ID: <76c5b8581002021609i4c05d039k35979757fbb74676@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.1.00.1002030056480.4985@pacific.mpi-cbg.de>

> Sorry, your "if message was not saved, abort" is so out of line with any
> program I use that this would be highly confusing (maybe "complicated" was
> the wrong choice of words).

Frankly, i think it is in line with "git commit" and that's the only
thing that matters here as I have no idea what programs you're talking
about. If your programs are working without making sure that user
confirmed whatever he actually supposed to confirm, then you probably
should revisit them;)

Thanks,
Eugene

  reply	other threads:[~2010-02-03  0:09 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-02 20:07 [BUG] - "git commit --amend" commits, when exiting the editor with no changes written Eugene Sajine
2010-02-02 20:14 ` Jacob Helwig
2010-02-02 20:27   ` Avery Pennarun
2010-02-02 20:47     ` Eugene Sajine
2010-02-02 20:58       ` Wincent Colaiuta
2010-02-02 21:56         ` Eugene Sajine
2010-02-02 22:03           ` Erik Faye-Lund
2010-02-02 22:06           ` Wincent Colaiuta
2010-02-02 22:31             ` Eugene Sajine
2010-02-02 22:35               ` Avery Pennarun
2010-02-02 23:02                 ` Eugene Sajine
2010-02-02 23:15                   ` Johannes Schindelin
2010-02-02 23:27                     ` Eugene Sajine
2010-02-02 23:40                   ` Avery Pennarun
2010-02-03  6:15                     ` Larry D'Anna
2010-02-03  9:31                       ` Jeff King
2010-02-03 10:15                         ` Jeff King
2010-02-03 18:19                         ` Avery Pennarun
2010-02-02 23:00               ` Johannes Schindelin
2010-02-02 23:34                 ` Eugene Sajine
2010-02-02 23:40                   ` Erik Faye-Lund
2010-02-02 23:48                     ` Eugene Sajine
2010-02-03  0:16                       ` Erik Faye-Lund
2010-02-03  0:55                         ` Eugene Sajine
2010-02-03  1:59                           ` SZEDER Gábor
2010-02-03  7:34                             ` Matthieu Moy
2010-02-03  9:08                               ` aborting rebase -i right at the start, was " Johannes Schindelin
2010-02-03  9:41                                 ` SZEDER Gábor
2010-02-03 16:02                                   ` Eugene Sajine
2010-02-03  7:31                       ` Matthieu Moy
2010-02-03 15:45                         ` Eugene Sajine
2010-02-03 17:51                           ` Jonathan Nieder
2010-02-03 17:53                             ` Jonathan Nieder
2010-02-03 18:21                           ` Wincent Colaiuta
2010-02-03 18:49                             ` Eugene Sajine
2010-02-03 18:57                               ` Avery Pennarun
2010-02-03 19:27                                 ` Eugene Sajine
2010-02-03 19:54                                   ` Avery Pennarun
2010-02-03 18:47                           ` Matthieu Moy
2010-02-02 23:58                   ` Johannes Schindelin
2010-02-03  0:09                     ` Eugene Sajine [this message]
2010-02-03  9:04                       ` Johannes Schindelin
2010-02-03  9:46                       ` Paolo Bonzini
2010-02-02 23:44                 ` Junio C Hamano
2010-02-02 21:18       ` Avery Pennarun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=76c5b8581002021609i4c05d039k35979757fbb74676@mail.gmail.com \
    --to=euguess@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=apenwarr@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jacob.helwig@gmail.com \
    --cc=win@wincent.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).