git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "René Scharfe" <l.s.r@web.de>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>, H Z <shiyuyuranzh@gmail.com>,
	Patrick Steinhardt <ps@pks.im>,
	git@vger.kernel.org
Subject: [PATCH v2] reftable: release name on reftable_reader_new() error
Date: Tue, 4 Mar 2025 17:11:54 +0100	[thread overview]
Message-ID: <77e1fe2e-f652-4aea-bc12-4deae7bcd569@web.de> (raw)
In-Reply-To: <20250304063329.GA1283445@coredump.intra.peff.net>

If block_source_read_block() or parse_footer() fail, we leak the "name"
member of struct reftable_reader in reftable_reader_new().  Release it.

Reported by: H Z <shiyuyuranzh@gmail.com>
Helped-by: Jeff King <peff@peff.net>
Signed-off-by: René Scharfe <l.s.r@web.de>
---
Change since v1: Avoid NULL pointer dereference.  Thank you, Peff!

 reftable/reader.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/reftable/reader.c b/reftable/reader.c
index 3f2e4b2800..24bae50ac2 100644
--- a/reftable/reader.c
+++ b/reftable/reader.c
@@ -666,6 +666,8 @@ int reftable_reader_new(struct reftable_reader **out,
 	reftable_block_done(&footer);
 	reftable_block_done(&header);
 	if (err) {
+		if (r)
+			reftable_free(r->name);
 		reftable_free(r);
 		block_source_close(source);
 	}
--
2.48.1

      parent reply	other threads:[~2025-03-04 16:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-01  6:07 Subject: Memory Leak vulnerability in reftable/readwrite_test.c H Z
2025-03-01  6:10 ` H Z
2025-03-01 11:31 ` René Scharfe
2025-03-01 11:34   ` H Z
2025-03-04  6:33   ` Jeff King
2025-03-04  7:39     ` H Z
2025-03-04 16:11     ` René Scharfe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=77e1fe2e-f652-4aea-bc12-4deae7bcd569@web.de \
    --to=l.s.r@web.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    --cc=ps@pks.im \
    --cc=shiyuyuranzh@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).