git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Boyd <bebarino@gmail.com>
To: git@vger.kernel.org
Subject: [PATCH 0/3] format-patch --attach/--inline use filename instead of  sha1
Date: Wed, 18 Mar 2009 12:51:11 -0700	[thread overview]
Message-ID: <780e0a6b0903181251t58b15a3asc5f9cc50564e11d0@mail.gmail.com> (raw)

This patch series modifies the behavior of format-patch when used with
the --attach or --inline command line settings. Current behavior names
the attached or inlined patches with the sha1 of the commit, which
isn't very friendly or easy for a human to use when downloading the
attachments. This series replaces the sha1 values with the filename
used by format-patch when it outputs the patches to files.

I don't know the guidelines to modifying the rev_info struct, so
hopefully adding the filename there is not bad.

Stephen Boyd (3):
  format-patch: remove unused total parameter from reopen_stdout()
  format-patch: create patch filename in get_patch_filename()
  format-patch: --attach/inline uses filename instead of sha1

 builtin-log.c                                      |   48 ++++++++++----------
 log-tree.c                                         |    8 ++--
 revision.h                                         |    1 +
 ....format-patch_--attach_--stdout_initial..master |   12 +++---
 ...format-patch_--attach_--stdout_initial..master^ |    8 ++--
 ...ff.format-patch_--attach_--stdout_initial..side |    4 +-
 ...tdout_--subject-prefix=TESTCASE_initial..master |   12 +++---
 ....format-patch_--inline_--stdout_initial..master |   12 +++---
 ...format-patch_--inline_--stdout_initial..master^ |    8 ++--
 ...ormat-patch_--inline_--stdout_initial..master^^ |    4 +-
 ...ff.format-patch_--inline_--stdout_initial..side |    4 +-
 11 files changed, 61 insertions(+), 60 deletions(-)

                 reply	other threads:[~2009-03-18 19:52 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=780e0a6b0903181251t58b15a3asc5f9cc50564e11d0@mail.gmail.com \
    --to=bebarino@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).