git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Boyd <bebarino@gmail.com>
To: Markus Heidelberg <markus.heidelberg@web.de>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] show-branch: color the commit status signs
Date: Wed, 22 Apr 2009 12:26:55 -0700	[thread overview]
Message-ID: <780e0a6b0904221226s43a40a12k8bf83de12fa7815d@mail.gmail.com> (raw)
In-Reply-To: <1240350779-9686-1-git-send-email-markus.heidelberg@web.de>

On Tue, Apr 21, 2009, Markus Heidelberg <markus.heidelberg@web.de> wrote:
> +--color::
> +       Color the status sign of the commits. Each branch uses a single color.

I don't know what the status sign of a commit is without reading your commit
message. Maybe reword this to be:

Color the status sign ('*' '!' '+' '-') of each commit corresponding
to the branch
it's in.

> +static char column_colors[][COLOR_MAXLEN] = {
> +       GIT_COLOR_RED,
> +       GIT_COLOR_GREEN,
> +       GIT_COLOR_YELLOW,
> +       GIT_COLOR_BLUE,
> +       GIT_COLOR_MAGENTA,
> +       GIT_COLOR_CYAN,
> +};
> +
> +#define COLUMN_COLORS_MAX (ARRAY_SIZE(column_colors))

This looks like a copy/paste (with a small edit) from graph.c so maybe you
want to refactor the original code from graph.c to color.h?

  reply	other threads:[~2009-04-22 19:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-21 21:52 [PATCH] show-branch: color the commit status signs Markus Heidelberg
2009-04-22 19:26 ` Stephen Boyd [this message]
2009-04-22 20:45   ` Markus Heidelberg
2009-04-22 21:16     ` Junio C Hamano
2009-04-22 21:41       ` [PATCH v2] " Markus Heidelberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=780e0a6b0904221226s43a40a12k8bf83de12fa7815d@mail.gmail.com \
    --to=bebarino@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=markus.heidelberg@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).